You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@opendal.apache.org by "nasen23 (via GitHub)" <gi...@apache.org> on 2023/03/28 05:45:02 UTC

[GitHub] [incubator-opendal] nasen23 commented on a diff in pull request #1784: feat: Add support for list and list_with_delimiter

nasen23 commented on code in PR #1784:
URL: https://github.com/apache/incubator-opendal/pull/1784#discussion_r1150055003


##########
bindings/object_store/src/lib.rs:
##########
@@ -196,6 +251,22 @@ fn format_object_store_error(err: opendal::Error, path: &str) -> object_store::E
     }
 }
 
+fn convert_entry(entry: &Entry, meta: &Metadata) -> ObjectMeta {

Review Comment:
   That looks good. Fixed!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org