You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "MasamiYui (via GitHub)" <gi...@apache.org> on 2025/03/16 13:06:39 UTC
[PR] Feature] alarm webhook support bearer auth [skywalking]
MasamiYui opened a new pull request, #13106:
URL: https://github.com/apache/skywalking/pull/13106
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
- [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #13095
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997612822
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -31,10 +32,33 @@
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @AllArgsConstructor
+ @Setter
+ @Getter
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
Review Comment:
You seem to never use this `#type` and validate the value.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "MasamiYui (via GitHub)" <gi...@apache.org>.
MasamiYui commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997644349
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
+ private final String credentials;
+
+ public void validate() {
+ if (WebhookAuthType.typeOf(type) == null) {
+ throw new IllegalArgumentException("Unsupported authorization: " + type);
+ }
Review Comment:
validate in WebhookAuthType#nameOf and Authorization#constructor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#issuecomment-2728202715
> > This implementation is too strict and specific. Consider allowing users to set arbitrary http headers, which can cover many authorizations like Basic/Bearer or company-specific authorization headers.
>
>
>
> Do you ask to set up any auth header value?
Not necessarily auth header. Just allow users to set arbitrary http headers, can it be anything like `Authorization: Basic <basic-token>`, `Authorization: Bearer <bearer token>` or `x-company-token: <company internal authorization token>`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997631628
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
+ private final String credentials;
+
+ public void validate() {
+ if (WebhookAuthType.typeOf(type) == null) {
+ throw new IllegalArgumentException("Unsupported authorization: " + type);
+ }
Review Comment:
I think we should validate this in constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#issuecomment-2728208880
So, it could be a list of extrax header, and any header based auth is satisfied.
@MasamiYui Please follow this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add http headers configuration for webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1998597190
##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -189,6 +189,22 @@ webhook:
urls:
- http://ip:port/xxx
- http://ip:port/yyy
+ custom1:
+ urls:
+ - http://127.0.0.1/custom1
+ headers:
Review Comment:
```suggestion
# headers config is provided to add custom configurations or authentications that are required from the server side.
headers:
```
##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -189,6 +189,22 @@ webhook:
urls:
- http://ip:port/xxx
- http://ip:port/yyy
+ custom1:
+ urls:
+ - http://127.0.0.1/custom1
+ headers:
+ Authorization: Bearer bearer_token
+ custom2:
+ urls:
+ - http://127.0.0.1/custom2
+ headers:
Review Comment:
```suggestion
# headers config is provided to add custom configurations or authentications that are required from the server
headers:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997631833
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
+ private final String credentials;
+
+ public void validate() {
+ if (WebhookAuthType.typeOf(type) == null) {
+ throw new IllegalArgumentException("Unsupported authorization: " + type);
+ }
+ if (StringUtil.isEmpty(credentials)) {
+ throw new IllegalArgumentException("Credentials cannot be null or empty");
+ }
+ }
+ }
+
+ public Map<String, String> getAuthHeaders(){
+ HashMap<String, String> headers = new HashMap<>();
+ if (authorization != null){
+ headers.put("Authorization", "Bearer " + this.authorization.credentials);
+ }
Review Comment:
This header build should base on `type==WebhookAuthType#BEARER`
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
Review Comment:
```suggestion
private final WebhookAuthType type;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add HTTP headers configuration for webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #13106:
URL: https://github.com/apache/skywalking/pull/13106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "MasamiYui (via GitHub)" <gi...@apache.org>.
MasamiYui commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997644473
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
Review Comment:
done
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
+ private final String credentials;
+
+ public void validate() {
+ if (WebhookAuthType.typeOf(type) == null) {
+ throw new IllegalArgumentException("Unsupported authorization: " + type);
+ }
+ if (StringUtil.isEmpty(credentials)) {
+ throw new IllegalArgumentException("Credentials cannot be null or empty");
+ }
+ }
+ }
+
+ public Map<String, String> getAuthHeaders(){
+ HashMap<String, String> headers = new HashMap<>();
+ if (authorization != null){
+ headers.put("Authorization", "Bearer " + this.authorization.credentials);
+ }
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#issuecomment-2728221898
For reference, the config style can be:
```yaml
custom1:
urls:
- http://127.0.0.1/custom1
headers:
Authorization: Bearer bearer_token
custom2:
urls:
- http://127.0.0.1/custom2
headers:
Authorization: Basic basic-token
custom3:
urls:
- http://127.0.0.1/internal-hook
headers:
x-company-token: whatever-token-defined-internally-within-the-company
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#issuecomment-2727426457
BTW, we were facing https://semgrep.dev/blog/2025/popular-github-action-tj-actionschanged-files-is-compromised/ .
The ASF Infra asked us to use `dorny/paths-filter`. Wait for @kezhenxu94 to adjust our CI. Before that, most UTs and e2e tests would not run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "MasamiYui (via GitHub)" <gi...@apache.org>.
MasamiYui commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997624724
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -31,10 +32,33 @@
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @AllArgsConstructor
+ @Setter
+ @Getter
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
Review Comment:
Add validate for config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#issuecomment-2728150276
> This implementation is too strict and specific. Consider allowing users to set arbitrary http headers, which can cover many authorizations like Basic/Bearer or company-specific authorization headers.
Do you ask to set up any auth header value?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add bearer auth configuration for http webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1997631968
##########
oap-server/server-alarm-plugin/src/main/java/org/apache/skywalking/oap/server/core/alarm/provider/webhook/WebhookSettings.java:
##########
@@ -18,23 +18,57 @@
package org.apache.skywalking.oap.server.core.alarm.provider.webhook;
-import java.util.ArrayList;
-import java.util.List;
+import java.util.*;
+
+import lombok.Builder;
+import lombok.Data;
import lombok.Getter;
import lombok.Setter;
import lombok.ToString;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHookSettings;
import org.apache.skywalking.oap.server.core.alarm.provider.AlarmHooksType;
+import org.apache.skywalking.oap.server.library.util.StringUtil;
@Setter
@Getter
@ToString
public class WebhookSettings extends AlarmHookSettings {
private List<String> urls = new ArrayList<>();
+ private Authorization authorization;
+
public WebhookSettings(final String name,
final AlarmHooksType type,
final boolean isDefault) {
super(name, type, isDefault);
+
+ }
+
+ @Builder
+ @Data
+ @ToString
+ public static class Authorization {
+ /**
+ * @see WebhookAuthType
+ */
+ private final String type;
+ private final String credentials;
+
+ public void validate() {
+ if (WebhookAuthType.typeOf(type) == null) {
+ throw new IllegalArgumentException("Unsupported authorization: " + type);
+ }
Review Comment:
This extra method is not necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add http headers configuration for webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1998434681
##########
docs/en/changes/changes.md:
##########
@@ -84,6 +84,7 @@
* Bump Armeria to 1.32.0 and some transitive dependencies.
* Skip persisting metrics/record data that have been expired.
* Fix the issue of missing Last Ping data.
+* Add Http headers configuration for webhook.
Review Comment:
```suggestion
* Add HTTP headers configuration for the alarm webhook.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add http headers configuration for webhook [skywalking]
Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #13106:
URL: https://github.com/apache/skywalking/pull/13106#discussion_r1998597708
##########
docs/en/setup/backend/backend-alarm.md:
##########
@@ -189,6 +189,22 @@ webhook:
urls:
- http://ip:port/xxx
- http://ip:port/yyy
+ custom1:
+ urls:
+ - http://127.0.0.1/custom1
+ headers:
+ Authorization: Bearer bearer_token
+ custom2:
+ urls:
+ - http://127.0.0.1/custom2
+ headers:
+ Authorization: Basic basic_token
+ custom3:
+ urls:
+ - http://127.0.0.1/internal-hook
+ headers:
Review Comment:
```suggestion
# headers config is provided to add custom configurations or authentications that are required from the server
headers:
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org