You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/23 12:51:21 UTC

[GitHub] [flink] zentol opened a new pull request, #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

zentol opened a new pull request, #20059:
URL: https://github.com/apache/flink/pull/20059

   Use the same module structure for csv/json as for other formats for consistency, and remove a shade-plugin special case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

Posted by GitBox <gi...@apache.org>.
zentol merged PR #20059:
URL: https://github.com/apache/flink/pull/20059


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on a diff in pull request #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

Posted by GitBox <gi...@apache.org>.
zentol commented on code in PR #20059:
URL: https://github.com/apache/flink/pull/20059#discussion_r905780902


##########
flink-formats/flink-sql-csv/pom.xml:
##########
@@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+	
+	<modelVersion>4.0.0</modelVersion>
+
+	<parent>
+		<groupId>org.apache.flink</groupId>
+		<artifactId>flink-formats</artifactId>
+		<version>1.16-SNAPSHOT</version>
+	</parent>
+
+	<artifactId>flink-sql-csv</artifactId>
+	<name>Flink : Formats : SQL Avro</name>

Review Comment:
   ```suggestion
   	<name>Flink : Formats : SQL Csv</name>
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zhoulii commented on a diff in pull request #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

Posted by GitBox <gi...@apache.org>.
zhoulii commented on code in PR #20059:
URL: https://github.com/apache/flink/pull/20059#discussion_r905681337


##########
flink-formats/flink-sql-csv/pom.xml:
##########
@@ -0,0 +1,69 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+		xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
+	
+	<modelVersion>4.0.0</modelVersion>
+
+	<parent>
+		<groupId>org.apache.flink</groupId>
+		<artifactId>flink-formats</artifactId>
+		<version>1.16-SNAPSHOT</version>
+	</parent>
+
+	<artifactId>flink-sql-csv</artifactId>
+	<name>Flink : Formats : SQL Avro</name>

Review Comment:
   `Flink : Formats : SQL Avro` -> `Flink : Formats : SQL Csv`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20059:
URL: https://github.com/apache/flink/pull/20059#issuecomment-1164372003

   Alternatively we could just drop the unused sql-jar profiles and not create sql-jars at all for these formats, on the assumption that they will continue to be bundled with Flink.
   But I think it could be confusing for users when they look for sql-jars and don't see csv/json.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20059: [FLINK-28222][formats] Add sql modules for csv/json formats

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20059:
URL: https://github.com/apache/flink/pull/20059#issuecomment-1164379667

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "b3d65a1e82c85879e1265a069f318daec61b024c",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "b3d65a1e82c85879e1265a069f318daec61b024c",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * b3d65a1e82c85879e1265a069f318daec61b024c UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org