You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2010/01/27 02:54:48 UTC

[Bug 6310] New: sa-learn --import gives Insecure dependency in open

https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

           Summary: sa-learn --import gives Insecure dependency in open
           Product: Spamassassin
           Version: 3.3.0
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: P5
         Component: Learner
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: Mark.Martinec@ijs.si


David Morton writes (on the mailing list):

Trying to import a bayes db, I get:

#sa-learn --import
bayes: perform_upgrade: Insecure dependency in open while running with
-T switch at /usr/share/perl/5.8/File/Copy.pm line 133.

perl 5.8.8

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #7 from Mark Martinec <Ma...@ijs.si> 2010-03-02 23:06:24 UTC ---
Thanks!

3.3:
Bug 6310: sa-learn --import gives Insecure dependency in open
Sending lib/Mail/SpamAssassin/BayesStore/DBM.pm
Committed revision 918242.


Fixed. As test is still desired.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Libraries                   |Learner

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@issues.apache.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P4                          |P5

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P2                          |P4
            Summary|[review] sa-learn --import  |[test] sa-learn --import
                   |gives Insecure dependency   |gives Insecure dependency
                   |in open                     |in open

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|sa-learn --import gives     |[review] sa-learn --import
                   |Insecure dependency in open |gives Insecure dependency
                   |                            |in open
  Status Whiteboard|                            |needs 2 votes

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #12 from Mark Martinec <Ma...@ijs.si> 2011-05-11 12:37:24 UTC ---
Closing, this specific issue has been resolved for 3.3.2 .

There is no specific test for this, the bug may pop up anywhere,
we just need to chase and work around any such occurrence if/when
it happens.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #5 from Mark Martinec <Ma...@ijs.si> 2010-01-27 06:25:27 UTC ---
spamassassin-trunk$ svn -m 'Bug 6310 - sa-learn --import gives Insecure
dependency in open' ci
Sending lib/Mail/SpamAssassin/BayesStore/DBM.pm
Committed revision 903657.


Needs one more vote for inclusion in 3.3.1,
and needs a test.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 2 votes               |needs 1 vote

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jm@jmason.org

--- Comment #3 from Justin Mason <jm...@jmason.org> 2010-01-27 02:14:02 UTC ---
+1

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P5                          |P3
   Target Milestone|Undefined                   |3.3.1

--- Comment #2 from Mark Martinec <Ma...@ijs.si> 2010-01-26 17:58:13 UTC ---
David Morton writes:

> Thanks Mark, I can confirm that works for me.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #11 from Mark Martinec <Ma...@ijs.si> 2010-03-30 18:15:22 UTC ---
> btw we should have a test for this, too; please don't resolve the bug
> until we do

I don't think the test is really necessary. The issue is well understood
(see comment 10), and can pop up practically anywhere where underlying
perl module makes assumptions about $1, $2, ... not being tainted.

The issue will go away with Perl 5.13 - until then we'll just need
to cover any documented cases that will pop up. Luckily all known
or reported cases so far have been provided with a workaround fix
by now, along with a couple of preventive (just in case) measures.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #4 from Justin Mason <jm...@jmason.org> 2010-01-27 02:14:36 UTC ---
btw we should have a test for this, too; please don't resolve the bug until we
do

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #1 from Mark Martinec <Ma...@ijs.si> 2010-01-26 17:56:58 UTC ---
Created an attachment (id=4661)
 --> (https://issues.apache.org/SpamAssassin/attachment.cgi?id=4661)
proposed patch

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Justin Mason <jm...@jmason.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|ready to go                 |needs t script

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|needs 1 vote                |ready to go

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Mark Martinec <Ma...@ijs.si> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Priority|P3                          |P2

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

--- Comment #10 from Mark Martinec <Ma...@ijs.si> 2010-03-25 12:40:10 UTC ---
Btw, fixed in perl 5.12 / 5.13:


--------
Now fixed by commit 447ee1343739cf8e34c4ff1ba9b30eae75c3f1ab
in branch davem/post-5.12, which should be merged back into blead
once 5.12 has been released, and thus appear in 5.13 onwards:

commit 447ee1343739cf8e34c4ff1ba9b30eae75c3f1ab
Author:     David Mitchell <da...@iabyn.com>
AuthorDate: Thu Mar 25 10:56:35 2010 +0000
Commit:     David Mitchell <da...@iabyn.com>
CommitDate: Thu Mar 25 10:56:35 2010 +0000

    RT #67962: $1 treated as tainted in untainted match

    Fix the issue in the following:

        use re 'taint';
        $tainted =~ /(...)/;
        # $1 now correctly tainted
        $untainted =~ s/(...)/$1/;
        # $untainted now incorrectly tainted

    The problem stems from when $1 is updated.

    pp_substcont, which is called after the replacement expression has been
    evaluated, checks the returned expression for taintedness, and if so,
    taints the variable being substituted. For a substitution like
    s/(...)/x$1/ this works fine: the expression "x".$1 causes $1's get magic
    to be called, which sets $1 based on the recent match, and is marked as
    not tainted.  Thus the returned expression is untainted. In the variant
    s/(...)/$1/, the returned value on the stack is $1 itself, and its get
    magic hasn't been called yet. So it still has the tainted flag from the
    previous pattern.

    The solution is to mg_get the returned expression before testing for
    taintedness.


Affected files ...

    M   pp_ctl.c
    M   t/op/taint.t

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [test] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Karsten Bräckelmann <gu...@rudersport.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
              Group|security                    |
          Component|Security                    |Libraries
         AssignedTo|security@spamassassin.apach |dev@spamassassin.apache.org
                   |e.org                       |

--- Comment #9 from Karsten Bräckelmann <gu...@rudersport.de> 2010-03-23 17:43:12 UTC ---
Moving back off of Security, which got changed by accident during the mass
Target Milestone move.

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 6310] [review] sa-learn --import gives Insecure dependency in open

Posted by bu...@bugzilla.spamassassin.org.
https://issues.apache.org/SpamAssassin/show_bug.cgi?id=6310

Kevin A. McGrail <km...@pccc.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |kmcgrail@pccc.com

--- Comment #6 from Kevin A. McGrail <km...@pccc.com> 2010-03-02 20:11:06 UTC ---
+1 KAM

-- 
Configure bugmail: https://issues.apache.org/SpamAssassin/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.