[GitHub] [cloudstack] weizhouapache commented on a change in pull request #5348: security group: fix component test test_multiple_nic_support.py failures

[GitBox <gi...@apache.org>]

weizhouapache commented on a change in pull request #5348:
URL: https://github.com/apache/cloudstack/pull/5348#discussion_r692886230



##########
File path: test/integration/component/test_multiple_nic_support.py
##########
@@ -224,7 +224,7 @@ def setUpClass(cls):
                     cls.virtual_machine1.default_network_id = nic.networkid
                     break
         except Exception as e:
-            cls.fail("Exception while deploying virtual machine: %s" % e)
+            cls.fail(f"Exception while deploying virtual machine: {e}")

Review comment:
       @DaanHoogland 
   a bit strange that this does not work in centos7/python2
   
   ```
   ======================================================================
   ERROR: Failure: SyntaxError (invalid syntax (test_multiple_nic_support.py, line 227))
   ----------------------------------------------------------------------
   Traceback (most recent call last):
     File "/usr/lib/python2.7/site-packages/nose/case.py", line 132, in run
       self.beforeTest(result)
     File "/usr/lib/python2.7/site-packages/nose/case.py", line 74, in beforeTest
       beforeTest(self.test)
     File "/usr/lib/python2.7/site-packages/nose/proxy.py", line 117, in beforeTest
       self.plugins.beforeTest(self.test)
     File "/usr/lib/python2.7/site-packages/nose/plugins/manager.py", line 99, in __call__
       return self.call(*arg, **kw)
     File "/usr/lib/python2.7/site-packages/nose/plugins/manager.py", line 167, in simple
       result = meth(*arg, **kw)
     File "/usr/lib/python2.7/site-packages/marvin/marvinPlugin.py", line 174, in beforeTest
       join([self.__identifier, self.__testName])
   TypeError: sequence item 0: expected string, NoneType found
   -------------------- >> begin captured stdout << ---------------------
   === TestName: Failure: | Status : EXCEPTION ===
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org