You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@magpie.apache.org by "zbl1998-sdjn (via GitHub)" <gi...@apache.org> on 2026/07/15 14:46:11 UTC
[PR] docs(setup): fix pre-Magpie migration steps that became no-ops [magpie]
zbl1998-sdjn opened a new pull request, #877:
URL: https://github.com/apache/magpie/pull/877
## Summary
- The "Migrating a pre-Magpie (`apache-steward`) adopter" recipe in `docs/setup/install-recipes.md` had its source-side (old-layout) names swept from `apache-steward` to `apache-magpie` along with everything else, so the steps now move/rename paths to themselves. Step 3 reads "move `~/.config/apache-magpie/` to `~/.config/apache-magpie/`" — the no-op reported in #867.
- I restored the old-layout names to `apache-steward` (heading + intro, step 1, step 2's overrides-preserve clause, and step 3); destination paths stay `apache-magpie`. The direction is the mapping recorded in d856ce2 (#440) — the XDG dir moved `~/.config/apache-steward/` → `~/.config/apache-magpie/` — and it's still what `skills/setup/upgrade.md` does today.
- Updated the TOC anchor to match the renamed heading.
## Test plan
- `git diff` is 11 insertions / 11 deletions, all inside the one migration section — no other prose touched.
- Grepped the repo: nothing else links to the old `#migrating-a-pre-magpie-apache-magpie-adopter` anchor, so the heading rename breaks no cross-link.
- I didn't run `prek` locally — happy to adjust if doctoc / markdownlint / lychee flags anything.
Fixes #867
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(setup): fix pre-Magpie migration steps that became no-ops [magpie]
Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #877:
URL: https://github.com/apache/magpie/pull/877#discussion_r3588308377
##########
docs/setup/install-recipes.md:
##########
@@ -262,26 +262,26 @@ and updates the local lock. See
[`setup/upgrade.md`](../../skills/setup/upgrade.md)
for the full flow.
-## Migrating a pre-Magpie (`apache-magpie`) adopter
+## Migrating a pre-Magpie (`apache-steward`) adopter
A repo that adopted the framework **before** it was renamed from
-`apache-magpie` to **Apache Magpie** is on the old layout: a committed
-`.claude/skills/magpie-setup/` skill, an `.apache-magpie/` snapshot,
-`.apache-magpie.lock` / `.apache-magpie-overrides/`, un-prefixed
-framework symlinks, and `~/.config/apache-magpie/`. The framework
+`apache-steward` to **Apache Magpie** is on the old layout: a committed
+`.claude/skills/setup-steward/` skill, an `.apache-steward/` snapshot,
+`.apache-steward.lock` / `.apache-steward-overrides/`, un-prefixed
+framework symlinks, and `~/.config/apache-steward/`. The framework
**no longer ships an automated migration** for this layout — migrate by
hand:
Review Comment:
This section says the framework “no longer ships an automated migration” and instructs users to migrate by hand, but `/magpie-setup upgrade` explicitly performs the `apache-steward`→Magpie migration automatically (see `skills/setup/upgrade.md` Step 0a). This contradiction can mislead adopters into doing unnecessary manual work.
##########
docs/setup/install-recipes.md:
##########
@@ -262,26 +262,26 @@ and updates the local lock. See
[`setup/upgrade.md`](../../skills/setup/upgrade.md)
for the full flow.
-## Migrating a pre-Magpie (`apache-magpie`) adopter
+## Migrating a pre-Magpie (`apache-steward`) adopter
A repo that adopted the framework **before** it was renamed from
-`apache-magpie` to **Apache Magpie** is on the old layout: a committed
-`.claude/skills/magpie-setup/` skill, an `.apache-magpie/` snapshot,
-`.apache-magpie.lock` / `.apache-magpie-overrides/`, un-prefixed
-framework symlinks, and `~/.config/apache-magpie/`. The framework
+`apache-steward` to **Apache Magpie** is on the old layout: a committed
+`.claude/skills/setup-steward/` skill, an `.apache-steward/` snapshot,
+`.apache-steward.lock` / `.apache-steward-overrides/`, un-prefixed
+framework symlinks, and `~/.config/apache-steward/`. The framework
**no longer ships an automated migration** for this layout — migrate by
hand:
-1. Remove the legacy in-repo artefacts: `.apache-magpie*` (snapshot,
+1. Remove the legacy in-repo artefacts: `.apache-steward*` (snapshot,
locks, overrides), any un-prefixed framework symlinks under the
- skills dir, and the committed `.claude/skills/magpie-setup/` skill.
+ skills dir, and the committed `.claude/skills/setup-steward/` skill.
2. Re-adopt from scratch with `/magpie-setup` (see
[`setup/adopt.md`](../../skills/setup/adopt.md)) so the current
`.apache-magpie*` layout and `magpie-`-prefixed symlinks are written
- fresh. Preserve any `.apache-magpie-overrides/*.md` you want to keep
+ fresh. Preserve any `.apache-steward-overrides/*.md` you want to keep
by moving them into the new `.apache-magpie-overrides/` first.
Review Comment:
Step 2 suggests preserving only `.apache-steward-overrides/*.md`, but the overrides layer can include non-Markdown config (for example `.apache-magpie-overrides/security-tracker-stats.yaml` is referenced by `projects/_template/security-tracker-stats.md`). Preserving only `*.md` may cause adopters to lose important override files during migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(setup): fix pre-Magpie migration steps that became no-ops [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on code in PR #877:
URL: https://github.com/apache/magpie/pull/877#discussion_r3590445497
##########
docs/setup/install-recipes.md:
##########
@@ -262,26 +262,26 @@ and updates the local lock. See
[`setup/upgrade.md`](../../skills/setup/upgrade.md)
for the full flow.
-## Migrating a pre-Magpie (`apache-magpie`) adopter
+## Migrating a pre-Magpie (`apache-steward`) adopter
A repo that adopted the framework **before** it was renamed from
-`apache-magpie` to **Apache Magpie** is on the old layout: a committed
-`.claude/skills/magpie-setup/` skill, an `.apache-magpie/` snapshot,
-`.apache-magpie.lock` / `.apache-magpie-overrides/`, un-prefixed
-framework symlinks, and `~/.config/apache-magpie/`. The framework
+`apache-steward` to **Apache Magpie** is on the old layout: a committed
+`.claude/skills/setup-steward/` skill, an `.apache-steward/` snapshot,
+`.apache-steward.lock` / `.apache-steward-overrides/`, un-prefixed
+framework symlinks, and `~/.config/apache-steward/`. The framework
**no longer ships an automated migration** for this layout — migrate by
hand:
Review Comment:
it;s fine - it's pre-magpie
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] docs(setup): fix pre-Magpie migration steps that became no-ops [magpie]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #877:
URL: https://github.com/apache/magpie/pull/877
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@magpie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org