You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by "mistercrunch (via GitHub)" <gi...@apache.org> on 2024/08/01 00:02:13 UTC

Re: [PR] perf: Antd icons tree shaking [superset]

mistercrunch commented on code in PR #29787:
URL: https://github.com/apache/superset/pull/29787#discussion_r1699226880


##########
superset-frontend/src/components/Icons/AntdEnhanced.tsx:
##########
@@ -17,10 +17,94 @@
  * under the License.
  */
 
-import * as AntdIcons from '@ant-design/icons/lib/icons';
+import {

Review Comment:
   ok I added a commit with the comment - first time using that GH feature...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org