You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by "joerghoh (via GitHub)" <gi...@apache.org> on 2025/05/03 15:07:21 UTC
[PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
joerghoh opened a new pull request, #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56
* update oajv:org-apache-jackrabbit-vault to 3.8.4
* update oajv:vault-validation to 3.8.4
* added dependency to commongs-lang3
* updated test-dependency for Johnzon to 2.0.0 (because of the EE10 API)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2084572567
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
I added a ``NoopDependencyValidator`` for the moment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2084904636
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
@kwin is this what you were aiming for? (Excluding resolving the proper dependencies ... that's for another ticket.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073019108
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
You can instead leverage the newly exposed class `org.apache.jackrabbit.vault.validation.context.ArchiveValidationContext` instead of implementing this interface on your own. Compare with <https://issues.apache.org/jira/browse/JCRVLT-567>.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073946949
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
You don't resolve dependencies currently (https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/40a60fe7e5186a7eb695b1453ab30d6145c04647/src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java#L71) which may lead to other false negatives with certain validators, therefore currently just passing a noop one keeps the status quo. Long-term you should think about resolving those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#issuecomment-2848667290
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56) **Quality Gate failed**
Failed conditions
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073960306
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
Implementing a working dependency resolver shouldn't be too hard though when just extending https://github.com/apache/jackrabbit-filevault/blob/master/vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/context/AbstractDependencyResolver.java (https://issues.apache.org/jira/browse/JCRVLT-774)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh merged PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073019108
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
You can instead leverage the newly exposed class `org.apache.jackrabbit.vault.validation.context.ArchiveValidationContext` instead of implementing this interface on your own.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "sonarqubecloud[bot] (via GitHub)" <gi...@apache.org>.
sonarqubecloud[bot] commented on PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#issuecomment-2872430959
## [](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56) **Quality Gate failed**
Failed conditions
 [66.7% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56&metric=new_coverage&view=list) (required ≥ 80%)
[See analysis details on SonarQube Cloud](https://sonarcloud.io/dashboard?id=apache_sling-org-apache-sling-feature-analyser&pullRequest=56)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073925723
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
Good pointer, although I feel that the use of ``org.apache.jackrabbit.vault.validation.context.ArchiveValidationContext`` complicates the situation, as it also requires a ``DependencyResolver``, which I couldn't find out howto create it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "joerghoh (via GitHub)" <gi...@apache.org>.
joerghoh commented on PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#issuecomment-2848669757
@jsedding @cziegeler : can you please have a look at it? I am not super comfortable throwing the ``UnsupportedMethodException`` in ``ArchiveValidationContextImpl``, but the tests ran without any implementation of them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073946949
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
You don't resolve dependencies currently (https://github.com/apache/sling-org-apache-sling-feature-analyser/blob/40a60fe7e5186a7eb695b1453ab30d6145c04647/src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java#L71) which may lead to other false negatives with certain validators, therefore currently just passing a noop `DependencyResolver` keeps the status quo. Long-term you should think about resolving those.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "cziegeler (via GitHub)" <gi...@apache.org>.
cziegeler commented on PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#issuecomment-2849377087
I am not familiar with that context object, but I guess this is fine. If it ever causes problems it can be easily identified and then fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] SLING-12775 update file vault dependencies [sling-org-apache-sling-feature-analyser]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on code in PR #56:
URL: https://github.com/apache/sling-org-apache-sling-feature-analyser/pull/56#discussion_r2073025374
##########
src/main/java/org/apache/sling/feature/analyser/task/impl/contentpackage/ArchiveValidationContextImpl.java:
##########
@@ -69,4 +70,19 @@ public Path getPackageRootPath() {
public Collection<PackageInfo> getDependenciesPackageInfo() {
return Collections.emptyList();
}
+
+ @Override
+ public Object setAttribute(String name, Object value) {
Review Comment:
The context attributes are used from https://github.com/apache/jackrabbit-filevault/blob/c475237b2f529429a47ad029791561f7d9a6413c/vault-validation/src/main/java/org/apache/jackrabbit/vault/validation/spi/impl/OverlappingFilterValidatorFactory.java#L57.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org