You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/04/05 19:26:11 UTC

[GitHub] [zookeeper] enixon commented on a change in pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused

enixon commented on a change in pull request #895: ZOOKEEPER-3349: QuorumCnxManager socketTimeout unused
URL: https://github.com/apache/zookeeper/pull/895#discussion_r272715550
 
 

 ##########
 File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/quorum/QuorumPeer.java
 ##########
 @@ -2278,7 +2278,6 @@ public QuorumCnxManager createCnxnManager() {
                 this.getView(),
                 this.authServer,
                 this.authLearner,
-                this.tickTime * this.syncLimit,
 
 Review comment:
   This corresponds to removing `int socketTimeout` from the constructor of QuorumCnxManager.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services