[GitHub] [incubator-mxnet] roywei commented on a change in pull request #15156: fix kvstore nightly failure

[GitBox <gi...@apache.org>]

roywei commented on a change in pull request #15156: fix kvstore nightly failure
URL: https://github.com/apache/incubator-mxnet/pull/15156#discussion_r290978813
 
 

 ##########
 File path: docs/tutorials/python/kvstore.md
 ##########
 @@ -86,7 +86,7 @@ print(a.asnumpy())
 `[[ 4.  4.  4.],[ 4.  4.  4.]]`<!--notebook-skip-line-->
 
 ```python
-kv.push(3, mx.nd.ones(shape))
+kv.push(3, mx.nd.ones(shape, contexts[0]))
 
 Review comment:
   @apeforest had another discussion with @eric-haibin-lin , making it to a list of 4 CPU arrays will provide consistent result. If users has 1/2/3 GPUs, it will produce diffrent results compared to the value on tutorial, and may cause confusion. Also if only 1 GPU, it defeats the purpose of the tutorial.
   I have added a note saying sum will only happen if value list is larger than 1.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services