[GitHub] dpogue opened a new pull request #409: Another possible Xcode 10 fix

[GitBox <gi...@apache.org>]

dpogue opened a new pull request #409: Another possible Xcode 10 fix
URL: https://github.com/apache/cordova-ios/pull/409
 
 
   <!--
   Please make sure the checklist boxes are all checked before submitting the PR. The checklist
   is intended as a quick reference, for complete details please see our Contributor Guidelines:
   
   http://cordova.apache.org/contribute/contribute_guidelines.html
   
   Thanks!
   -->
   
   This is an alternative proposal to #408, but I lack the knowledge to make any definitive statements about one being better than the other. This one involves no source code changes, and the xcodeproj changes are fairly minimal overall.
   
   /cc @sgoldberg-sfdc 
   
   ### Platforms affected
   iOS
   
   ### What does this PR do?
   Updates the CordovaLib.xcodeproj and template xcodeproj files to use the recommended settings from Xcode 10. This appears to solve the problems with building in Xcode 10, but doesn't appear to break building in Xcode 9.
   
   ### What testing has been done on this change?
   Manual testing done with Xcode 10 GM and Xcode 9.4.1.
   Updated unit tests for new behaviour.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org