[GitHub] [airflow] bjankie1 commented on a diff in pull request #29498: add missing read for K8S config file from conn in deferred `KubernetesPodOperator`

["bjankie1 (via GitHub)" <gi...@apache.org>]

bjankie1 commented on code in PR #29498:
URL: https://github.com/apache/airflow/pull/29498#discussion_r1116981921


##########
airflow/providers/cncf/kubernetes/operators/kubernetes_pod.py:
##########
@@ -565,7 +565,16 @@ def execute_async(self, context: Context):
 
     def convert_config_file_to_dict(self):
         """Converts passed config_file to dict format."""
-        config_file = self.config_file if self.config_file else os.environ.get(KUBE_CONFIG_ENV_VAR)
+        config_file = None

Review Comment:
   Please mind that all FS operations are blocking side effects. It's violating asyncio contract and can cause additional error logs informing about blocking code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org