You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2023/06/17 05:46:43 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #20598: [refactor][auth] AuthenticationFilter.doFilter
tisonkun opened a new pull request, #20598:
URL: https://github.com/apache/pulsar/pull/20598
This is a follow-up to https://github.com/apache/pulsar/pull/19464.
### Motivation
Simplify code.
### Does this pull request potentially affect one of the following parts:
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
*If the box was checked, please highlight the changes*
- [ ] Dependencies (add or upgrade a dependency)
- [ ] The public API
- [ ] The schema
- [ ] The default values of configurations
- [ ] The threading model
- [ ] The binary protocol
- [ ] The REST endpoints
- [ ] The admin CLI options
- [ ] The metrics
- [ ] Anything that affects deployment
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece merged pull request #20598: [refactor][broker] AuthenticationFilter.doFilter
Posted by "nodece (via GitHub)" <gi...@apache.org>.
nodece merged PR #20598:
URL: https://github.com/apache/pulsar/pull/20598
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #20598: [refactor][broker] AuthenticationFilter.doFilter
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #20598:
URL: https://github.com/apache/pulsar/pull/20598#issuecomment-1595707037
## [Codecov](https://app.codecov.io/gh/apache/pulsar/pull/20598?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#20598](https://app.codecov.io/gh/apache/pulsar/pull/20598?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (0381828) into [master](https://app.codecov.io/gh/apache/pulsar/commit/a85e9df1e7c990aec10022815259d2644152677d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a85e9df) will **increase** coverage by `41.11%`.
> The diff coverage is `80.00%`.
[](https://app.codecov.io/gh/apache/pulsar/pull/20598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## master #20598 +/- ##
=============================================
+ Coverage 31.91% 73.02% +41.11%
- Complexity 11773 31975 +20202
=============================================
Files 1498 1867 +369
Lines 114598 138658 +24060
Branches 12426 15234 +2808
=============================================
+ Hits 36571 101257 +64686
+ Misses 73194 29363 -43831
- Partials 4833 8038 +3205
```
| Flag | Coverage Δ | |
|---|---|---|
| inttests | `24.15% <0.00%> (?)` | |
| systests | `24.89% <50.00%> (?)` | |
| unittests | `72.32% <80.00%> (+40.40%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://app.codecov.io/gh/apache/pulsar/pull/20598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...apache/pulsar/broker/web/AuthenticationFilter.java](https://app.codecov.io/gh/apache/pulsar/pull/20598?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cHVsc2FyLWJyb2tlci1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3B1bHNhci9icm9rZXIvd2ViL0F1dGhlbnRpY2F0aW9uRmlsdGVyLmphdmE=) | `90.47% <80.00%> (+32.78%)` | :arrow_up: |
... and [1552 files with indirect coverage changes](https://app.codecov.io/gh/apache/pulsar/pull/20598/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org