You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/22 11:57:17 UTC
[GitHub] [inlong] gosonzhang opened a new pull request, #5636: [INLONG-5633][Improve][DataProxy]Add statistical information to Http Source
gosonzhang opened a new pull request, #5636:
URL: https://github.com/apache/inlong/pull/5636
- Fixes #5633
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] dockerzhang commented on pull request #5636: [INLONG-5633][DataProxy] Add statistical information to the HTTP source
Posted by GitBox <gi...@apache.org>.
dockerzhang commented on PR #5636:
URL: https://github.com/apache/inlong/pull/5636#issuecomment-1223468800
@lucaspeng12138 PTAL, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] EMsnap commented on a diff in pull request #5636: [INLONG-5633][DataProxy] Add statistical information to the HTTP source
Posted by GitBox <gi...@apache.org>.
EMsnap commented on code in PR #5636:
URL: https://github.com/apache/inlong/pull/5636#discussion_r952072827
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/http/HttpBaseSource.java:
##########
@@ -48,64 +46,55 @@ public class HttpBaseSource extends AbstractSource implements EventDrivenSource,
protected String attr;
protected String messageHandlerName;
protected boolean filterEmptyMsg;
- protected CounterGroup counterGroup;
- protected CounterGroupExt counterGroupExt;
protected int maxConnections = Integer.MAX_VALUE;
protected boolean customProcessor = false;
protected Context context;
- private int statIntervalSec;
- private StatRunner statRunner;
- private Thread statThread;
+ // statistic
+ protected MonitorIndex monitorIndex = null;
+ protected MonitorIndexExt monitorIndexExt = null;
+ private int statIntervalSec = 60;
+ private int maxMonitorCnt = 300000;
Review Comment:
the default value is set already so no need to declare here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang merged pull request #5636: [INLONG-5633][DataProxy] Add statistical information to the HTTP source
Posted by GitBox <gi...@apache.org>.
gosonzhang merged PR #5636:
URL: https://github.com/apache/inlong/pull/5636
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] gosonzhang commented on a diff in pull request #5636: [INLONG-5633][DataProxy] Add statistical information to the HTTP source
Posted by GitBox <gi...@apache.org>.
gosonzhang commented on code in PR #5636:
URL: https://github.com/apache/inlong/pull/5636#discussion_r952114148
##########
inlong-dataproxy/dataproxy-source/src/main/java/org/apache/inlong/dataproxy/http/HttpBaseSource.java:
##########
@@ -48,64 +46,55 @@ public class HttpBaseSource extends AbstractSource implements EventDrivenSource,
protected String attr;
protected String messageHandlerName;
protected boolean filterEmptyMsg;
- protected CounterGroup counterGroup;
- protected CounterGroupExt counterGroupExt;
protected int maxConnections = Integer.MAX_VALUE;
protected boolean customProcessor = false;
protected Context context;
- private int statIntervalSec;
- private StatRunner statRunner;
- private Thread statThread;
+ // statistic
+ protected MonitorIndex monitorIndex = null;
+ protected MonitorIndexExt monitorIndexExt = null;
+ private int statIntervalSec = 60;
+ private int maxMonitorCnt = 300000;
Review Comment:
@EMsnap, this setting is necessary, regardless of whether the context() is called and whether the parameters are coded, these two parameters have data settings by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org