You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by mjsax <gi...@git.apache.org> on 2016/04/01 01:28:07 UTC
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
GitHub user mjsax opened a pull request:
https://github.com/apache/flink/pull/1844
[FLINK-3523] [Storm-Compatibility] Added SplitStreamMapper to program…
… to get rid of SplitStreamType wrapper
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mjsax/flink flink-3523-split-example
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1844.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1844
----
commit 8e518b548909b4604a427c3aca5fb2d33aabbb8f
Author: mjsax <mj...@informatik.hu-berlin.de>
Date: 2016-03-31T23:23:30Z
[FLINK-3523] [Storm-Compatibility] Added SplitStreamMapper to program to get rid of SplitStreamType wrapper
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205744485
For the test, two comments:
- Can you add it to another ITCase (saves bringing an extra mini cluster)
- Also, it will probably not run on windows. Writing to a temp file and deleting that should make this compatible.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-206214664
Test fail on Java8 module... Can I merge this @StephanEwen ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205283761
This is an additional example that runs forever -- it was never designed for getting tested. Furthermore, there are already two test for split-stream functionality.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205767304
Done. I needed to restructure class hierarchy, because `StreamingMultipleProgramsTestBase` did not provided methods for tmp-file handling...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1844
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-206344827
+1 to merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/1844#discussion_r58665510
--- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java ---
@@ -84,16 +86,27 @@ public static void main(final String[] args) throws Exception {
/**
* Same as {@link VerifyAndEnrichBolt}.
*/
- private final static class Enrich implements MapFunction<Integer, Tuple2<String, Integer>> {
+ public final static class Enrich implements MapFunction<Integer, Tuple2<String, Integer>> {
private static final long serialVersionUID = 5213888269197438892L;
private final Tuple2<String, Integer> out;
+ private final boolean evenOrOdd; // true: even -- false: odd
--- End diff --
How about `isEven` as name here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205286176
IMHO we should have a way to check that examples are working properly. We don't have to address this in this PR though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205299917
Change example slightly (make it run finite and added a check for even/odd stream) and added IT-Case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mjsax <gi...@git.apache.org>.
Github user mjsax commented on a diff in the pull request:
https://github.com/apache/flink/pull/1844#discussion_r58668244
--- Diff: flink-contrib/flink-storm-examples/src/main/java/org/apache/flink/storm/split/SpoutSplitExample.java ---
@@ -84,16 +86,27 @@ public static void main(final String[] args) throws Exception {
/**
* Same as {@link VerifyAndEnrichBolt}.
*/
- private final static class Enrich implements MapFunction<Integer, Tuple2<String, Integer>> {
+ public final static class Enrich implements MapFunction<Integer, Tuple2<String, Integer>> {
private static final long serialVersionUID = 5213888269197438892L;
private final Tuple2<String, Integer> out;
+ private final boolean evenOrOdd; // true: even -- false: odd
--- End diff --
Sure. Can change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-3523] [Storm-Compatibility] Added Split...
Posted by mxm <gi...@git.apache.org>.
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/1844#issuecomment-205282397
LGTM. Perhaps we could add a test case for this example?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---