You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/05/06 20:25:34 UTC
[GitHub] [fluo-muchos] arvindshmicrosoft opened a new pull request #346: Correctly check for Docker swarm status
arvindshmicrosoft opened a new pull request #346:
URL: https://github.com/apache/fluo-muchos/pull/346
Fixes #345 - which in turn was caused by extra whitespace now being
printed at the start of the line by `docker info`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #346: Correctly check for Docker swarm status
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #346:
URL: https://github.com/apache/fluo-muchos/pull/346#discussion_r421806129
##########
File path: ansible/docker.yml
##########
@@ -24,7 +24,7 @@
tasks:
- name: get swarm status
shell: >
- set -o pipefail && docker info | egrep '^Swarm: ' | cut -d ' ' -f 2
+ set -o pipefail && docker info | grep 'Swarm' | sed 's/\s*Swarm\:\s//'
Review comment:
Seems like the sed regex is expecting a `:` after Swarm, so I was thinking the grep could also have this to make it more specific. Also was wondering if would make sense to do `\s*` after `Swarm\:` in the sed regex.
```suggestion
set -o pipefail && docker info | grep 'Swarm:' | sed 's/\s*Swarm\:\s*//'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] milleruntime commented on a change in pull request #346: Correctly check for Docker swarm status
Posted by GitBox <gi...@apache.org>.
milleruntime commented on a change in pull request #346:
URL: https://github.com/apache/fluo-muchos/pull/346#discussion_r421629619
##########
File path: ansible/kill.yml
##########
@@ -30,7 +30,7 @@
- name: "stop mesos slaves"
service: name=mesos-slave state=stopped
when: "'mesosmaster' in groups"
-- hosts: all
+- hosts: all:!{{ azure_proxy_host }}
Review comment:
Why is this needed?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fluo-muchos] arvindshmicrosoft commented on a change in pull request #346: Correctly check for Docker swarm status
Posted by GitBox <gi...@apache.org>.
arvindshmicrosoft commented on a change in pull request #346:
URL: https://github.com/apache/fluo-muchos/pull/346#discussion_r421638782
##########
File path: ansible/kill.yml
##########
@@ -30,7 +30,7 @@
- name: "stop mesos slaves"
service: name=mesos-slave state=stopped
when: "'mesosmaster' in groups"
-- hosts: all
+- hosts: all:!{{ azure_proxy_host }}
Review comment:
The tasks within docker.yml install and bootstrap docker / swarm only on the workers and on swarmmanager hosts. But when kill / wipe are run, the above task to stop Docker would fail on `all` because in Azure there's a separate VM which gets setup as a proxy host (and that is not assigned a `worker` or `swarmmanager` role. So this is just addressing a dormant issue which came up when I tested the fix for the main issue in this thread.
##########
File path: ansible/kill.yml
##########
@@ -30,7 +30,7 @@
- name: "stop mesos slaves"
service: name=mesos-slave state=stopped
when: "'mesosmaster' in groups"
-- hosts: all
+- hosts: all:!{{ azure_proxy_host }}
Review comment:
The tasks within docker.yml install and bootstrap docker / swarm only on the workers and on swarmmanager hosts. But when kill / wipe are run, the above task to stop Docker would fail on `all` because in Azure there's a separate VM which gets setup as a proxy host (and that is not assigned a `worker` or `swarmmanager` role). So this is just addressing a dormant issue which came up when I tested the fix for the main issue in this thread.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org