[GitHub] [camel-quarkus] aldettinger commented on a change in pull request #3310: Graceful shutdown strategy used as default one

[GitBox <gi...@apache.org>]

aldettinger commented on a change in pull request #3310:
URL: https://github.com/apache/camel-quarkus/pull/3310#discussion_r753071325



##########
File path: extensions-core/core/deployment/src/main/java/org/apache/camel/quarkus/core/deployment/CamelContextProcessor.java
##########
@@ -102,6 +106,28 @@ CamelContextBuildItem context(
         return new CamelContextBuildItem(context);
     }
 
+    /**
+     * This step customizes camel context for development mode.
+     *
+     * @param recorder     the recorder
+     * @param capabilities the registered capabilities
+     * @param producer     producer of context customizer build item
+     */
+    @Record(ExecutionTime.STATIC_INIT)
+    @BuildStep(onlyIf = IsDevelopment.class)
+    public void developmenMode(
+            CamelContextRecorder recorder,
+            Capabilities capabilities,
+            BuildProducer<CamelContextCustomizerBuildItem> producer) {
+        if (capabilities.isPresent(CamelCapabilities.MAIN)) {
+            String val = CamelSupport.getOptionalConfigValue("camel.main.shutdownTimeout", String.class, null);
+            if (val == null) {
+                //if no graceful timeout is set in development mode, graceful shutdown is replaced with no shutdown
+                producer.produce(new CamelContextCustomizerBuildItem(recorder.createNoShutdownStrategyCustomizer()));
+            }
+        }

Review comment:
       Shouldn't we also set no shutdown strategy in DEV mode when no running with main ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org