[GitHub] [druid] jihoonson commented on issue #9305: Add support for optional cloud (aws, gcs, etc.) credentials for s3 for ingestion

[GitBox <gi...@apache.org>]

jihoonson commented on issue #9305: Add support for optional cloud (aws, gcs, etc.) credentials for s3 for ingestion
URL: https://github.com/apache/druid/issues/9305#issuecomment-583880150
 
 
   Hi @maytasm3, thank you for the nice proposal! This feature will be super useful. I have two comments on the new fields.
   
   - I think the new fields are pretty straightforward and the prefix "override" is not necessary. It's also confusing when you read from s3 but use some other storage type as deep storage than s3.
   - I think we may need more input-source-specific configurations such as `endpoint.url`, `endpoint.signingRegion`, and so on in the future. What do you think about adding a new field containing "accessKeyId" and "secretAccessKey" fields as below?
   
   ```json
         "inputSource": {
           "type": "s3",
           "prefixes": ["s3://foo/bar", "s3://bar/foo"],
           "properties": {
             "accessKeyId": "123455",
             "secretAccessKey": "masdjlaksjdlakjsd"
           }
         }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org