You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by li...@apache.org on 2021/01/08 02:27:09 UTC
[dubbo-samples] branch master updated: repair origin testcase (#203)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo-samples.git
The following commit(s) were added to refs/heads/master by this push:
new 771e08b repair origin testcase (#203)
771e08b is described below
commit 771e08b5288faa9022e81e77d2fb57fa35d6caef
Author: superalong <su...@gmail.com>
AuthorDate: Fri Jan 8 10:27:02 2021 +0800
repair origin testcase (#203)
---
dubbo-samples-grpc/dubbo-samples-original/pom.xml | 2 +-
.../java/org/apache/dubbo/samples/basic/OriginalGrpcIT.java | 12 ++++++++++--
2 files changed, 11 insertions(+), 3 deletions(-)
diff --git a/dubbo-samples-grpc/dubbo-samples-original/pom.xml b/dubbo-samples-grpc/dubbo-samples-original/pom.xml
index 03f008e..6c3448b 100644
--- a/dubbo-samples-grpc/dubbo-samples-original/pom.xml
+++ b/dubbo-samples-grpc/dubbo-samples-original/pom.xml
@@ -94,7 +94,7 @@
<dependency>
<groupId>org.testcontainers</groupId>
<artifactId>testcontainers</artifactId>
- <version>1.12.3</version>
+ <version>1.15.1</version>
<scope>test</scope>
</dependency>
</dependencies>
diff --git a/dubbo-samples-grpc/dubbo-samples-original/src/test/java/org/apache/dubbo/samples/basic/OriginalGrpcIT.java b/dubbo-samples-grpc/dubbo-samples-original/src/test/java/org/apache/dubbo/samples/basic/OriginalGrpcIT.java
index fe9edf1..be08b59 100644
--- a/dubbo-samples-grpc/dubbo-samples-original/src/test/java/org/apache/dubbo/samples/basic/OriginalGrpcIT.java
+++ b/dubbo-samples-grpc/dubbo-samples-original/src/test/java/org/apache/dubbo/samples/basic/OriginalGrpcIT.java
@@ -17,6 +17,9 @@
package org.apache.dubbo.samples.basic;
+import com.github.dockerjava.api.model.ExposedPort;
+import com.github.dockerjava.api.model.PortBinding;
+import com.github.dockerjava.api.model.Ports;
import io.grpc.examples.helloworld.DubboGreeterGrpc;
import io.grpc.examples.helloworld.HelloReply;
import io.grpc.examples.helloworld.HelloRequest;
@@ -30,6 +33,7 @@ import org.springframework.test.context.ContextConfiguration;
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
import org.testcontainers.containers.FixedHostPortGenericContainer;
import org.testcontainers.containers.GenericContainer;
+import org.testcontainers.utility.DockerImageName;
@RunWith(SpringJUnit4ClassRunner.class)
@ContextConfiguration(locations = {"classpath*:spring/dubbo-demo-consumer.xml", "classpath*:spring/dubbo-demo-provider.xml"})
@@ -49,8 +53,12 @@ public class OriginalGrpcIT {
//
// port mapping, https://github.com/testcontainers/testcontainers-java/issues/256
@ClassRule
- public static GenericContainer zookeeper = new FixedHostPortGenericContainer("zookeeper:3.4.9")
- .withFixedExposedPort(2181, 2181);
+ public static GenericContainer zookeeper = new GenericContainer<>(DockerImageName.parse("zookeeper:3.4.9"))
+ .withCreateContainerCmdModifier(
+ cmd ->{
+ cmd.withPortBindings(new PortBinding(Ports.Binding.bindPort(2181), new ExposedPort(2181)));
+ }
+ );
@Autowired
@Qualifier("greeter")
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org