You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Jimmy Xiang (JIRA)" <ji...@apache.org> on 2013/12/17 01:45:07 UTC
[jira] [Commented] (HBASE-10182) Potential null object deference in
AssignmentManager#handleRegion()
[ https://issues.apache.org/jira/browse/HBASE-10182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13849938#comment-13849938 ]
Jimmy Xiang commented on HBASE-10182:
-------------------------------------
Good catch.
> Potential null object deference in AssignmentManager#handleRegion()
> -------------------------------------------------------------------
>
> Key: HBASE-10182
> URL: https://issues.apache.org/jira/browse/HBASE-10182
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Priority: Trivial
>
> Here is the related code, starting line 921:
> {code}
> if (regionState == null
> || !regionState.isPendingOpenOrOpeningOnServer(sn)) {
> LOG.warn("Received OPENED for " + prettyPrintedRegionName
> + " from " + sn + " but the region isn't PENDING_OPEN/OPENING here: "
> + regionStates.getRegionState(encodedName));
> // Close it without updating the internal region states,
> // so as not to create double assignments in unlucky scenarios
> // mentioned in OpenRegionHandler#process
> unassign(regionState.getRegion(), null, -1, null, false, sn);
> {code}
> If regionState is null, we should not dereference it.
--
This message was sent by Atlassian JIRA
(v6.1.4#6159)