You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/08/19 13:44:09 UTC
[GitHub] [hudi] swuferhong opened a new pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
swuferhong opened a new pull request #3505:
URL: https://github.com/apache/hudi/pull/3505
…ethod call reflection
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
Fix ClassLoader error due to HoodieConfig$setDefaults() method call reflection. In method HoodieConfig$setDefaults(), we use `ReflectionUtils.getClass(configClassName);` to get configClass. In this method, using `Class.forName(clazzName, true, Thread.currentThread().getContextClassLoader());` to get ClassLoader. However, `currentThread().getContextClassLoader()` is unreasonable while runtime environment changes. The error log is as follows：
`
... 12 more
Caused by: org.apache.hudi.exception.HoodieException: Unable to load class
at org.apache.hudi.common.util.ReflectionUtils.getClass(ReflectionUtils.java:58) ~[?:?]
at org.apache.hudi.common.config.HoodieConfig.setDefaults(HoodieConfig.java:100) ~[?:?]
at org.apache.hudi.config.HoodieCompactionConfig.access$100(HoodieCompactionConfig.java:51) ~[?:?]
at org.apache.hudi.config.HoodieCompactionConfig$Builder.build(HoodieCompactionConfig.java:430) ~[?:?]
at org.apache.hudi.util.StreamerUtil.getHoodieClientConfig(StreamerUtil.java:171) ~[?:?]
at org.apache.hudi.util.StreamerUtil.createWriteClient(StreamerUtil.java:315) ~[?:?]
at org.apache.hudi.sink.StreamWriteOperatorCoordinator.start(StreamWriteOperatorCoordinator.java:158) ~[?:?]
at org.apache.flink.runtime.operators.coordination.OperatorCoordinatorHolder.start(OperatorCoordinatorHolder.java:194) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.DefaultOperatorCoordinatorHandler.startAllOperatorCoordinators(DefaultOperatorCoordinatorHandler.java:107) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.SchedulerBase.startScheduling(SchedulerBase.java:662) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.SchedulerNG.recoverAndStartScheduling(SchedulerNG.java:73) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.jobmaster.JobMaster.startJobExecution(JobMaster.java:897) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.jobmaster.JobMaster.onStart(JobMaster.java:393) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.RpcEndpoint.internalCallOnStart(RpcEndpoint.java:181) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.akka.AkkaRpcActor$StoppedState.start(AkkaRpcActor.java:605) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleControlMessage(AkkaRpcActor.java:180) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:26) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:21) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:21) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:170) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
... 12 more
Caused by: java.lang.ClassNotFoundException: org.apache.hudi.config.HoodieCompactionConfig
at java.net.URLClassLoader.findClass(URLClassLoader.java:381) ~[?:1.8.0_102]
at java.lang.ClassLoader.loadClass(ClassLoader.java:448) ~[?:1.8.0_102]
at sun.misc.Launcher$AppClassLoader.loadClass(Launcher.java:331) ~[?:1.8.0_102]
at java.lang.ClassLoader.loadClass(ClassLoader.java:380) ~[?:1.8.0_102]
at java.lang.Class.forName0(Native Method) ~[?:1.8.0_102]
at java.lang.Class.forName(Class.java:348) ~[?:1.8.0_102]
at org.apache.hudi.common.util.ReflectionUtils.getClass(ReflectionUtils.java:54) ~[?:?]
at org.apache.hudi.common.config.HoodieConfig.setDefaults(HoodieConfig.java:100) ~[?:?]
at org.apache.hudi.config.HoodieCompactionConfig.access$100(HoodieCompactionConfig.java:51) ~[?:?]
at org.apache.hudi.config.HoodieCompactionConfig$Builder.build(HoodieCompactionConfig.java:430) ~[?:?]
at org.apache.hudi.util.StreamerUtil.getHoodieClientConfig(StreamerUtil.java:171) ~[?:?]
at org.apache.hudi.util.StreamerUtil.createWriteClient(StreamerUtil.java:315) ~[?:?]
at org.apache.hudi.sink.StreamWriteOperatorCoordinator.start(StreamWriteOperatorCoordinator.java:158) ~[?:?]
at org.apache.flink.runtime.operators.coordination.OperatorCoordinatorHolder.start(OperatorCoordinatorHolder.java:194) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.DefaultOperatorCoordinatorHandler.startAllOperatorCoordinators(DefaultOperatorCoordinatorHandler.java:107) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.SchedulerBase.startScheduling(SchedulerBase.java:662) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.scheduler.SchedulerNG.recoverAndStartScheduling(SchedulerNG.java:73) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.jobmaster.JobMaster.startJobExecution(JobMaster.java:897) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.jobmaster.JobMaster.onStart(JobMaster.java:393) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.RpcEndpoint.internalCallOnStart(RpcEndpoint.java:181) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.akka.AkkaRpcActor$StoppedState.start(AkkaRpcActor.java:605) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at org.apache.flink.runtime.rpc.akka.AkkaRpcActor.handleControlMessage(AkkaRpcActor.java:180) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:26) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.apply(CaseStatements.scala:21) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at scala.PartialFunction$class.applyOrElse(PartialFunction.scala:123) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at akka.japi.pf.UnitCaseStatement.applyOrElse(CaseStatements.scala:21) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
at scala.PartialFunction$OrElse.applyOrElse(PartialFunction.scala:170) ~[flink-dist_2.11-1.13-vvr-4.0.9-rc8-SNAPSHOT.jar:1.13-vvr-4.0.9-rc8-SNAPSHOT]
... 12 more
`
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838) Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839)
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835)
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902386249
Cc the release manager @umehrot2 to chime in. I am interested in digging deeper here overall and see how we can make things better overall.
But IMO we have long past the release blocker phase for 0.9.0. We had ample call outs and sufficient time for landing all release blocker deemed PRs. We have to proceed as-is and we can follow up with a 0.9.1 right after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#discussion_r692336628
##########
File path: hudi-common/src/main/java/org/apache/hudi/common/config/HoodieConfig.java
##########
@@ -93,26 +95,12 @@ public HoodieConfig(Properties props) {
return Option.ofNullable(props.get(alternative));
}
}
+ if (setDefaultValue && configProperty.hasDefaultValue()) {
+ return Option.ofNullable(configProperty.defaultValue());
+ }
return Option.empty();
}
- protected void setDefaults(String configClassName) {
- Class<?> configClass = ReflectionUtils.getClass(configClassName);
- Arrays.stream(configClass.getDeclaredFields())
- .filter(f -> Modifier.isStatic(f.getModifiers()))
- .filter(f -> f.getType().isAssignableFrom(ConfigProperty.class))
- .forEach(f -> {
- try {
- ConfigProperty<?> cfgProp = (ConfigProperty<?>) f.get("null");
- if (cfgProp.hasDefaultValue()) {
- setDefaultValue(cfgProp);
- }
- } catch (IllegalAccessException e) {
- e.printStackTrace();
Review comment:
this is worth fixing and throwing a runtime error back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong closed pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong closed pull request #3505:
URL: https://github.com/apache/hudi/pull/3505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839)
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan edited a comment on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
nsivabalan edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902327023
@swuferhong @danny0405 @leesf : Trying to gauge the impact of this patch. sorry, I don't fully understand the patch yet from my quick skim thru. As per the description, I could infer that we could run into this issue "while runtime environment changes". Can someone help me understand what exactly does that mean?
We are working towards 2nd RC candidate. Can someone summarize what could happen if not for this patch. Is this something that effects core flow in hudi and does it affect all engines as well? in other words, is there a need to port this to the release branch (hot fix) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda185864d561d65911922f2a687ee16ca383d85 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda185864d561d65911922f2a687ee16ca383d85 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814)
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong commented on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902597944
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong commented on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902534404
@hudi-bot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902096633
I am not sure I fully understand this fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902408863
This is a much bigger topic. The config design. I actually think its solid. There are some files that we have not hit yet which are only internally used. Source of truth is the ConfigProperty members, but we need to set default values in the actual instant of a config obj such as HoodieCompactionConfig, without this reflection based auto registration, we have to manually add each property default value into the map. Lets focus on how to make reflection work safely with flink? :) Reflection is a fairly widely used jvm feature, we just need to understand how to make it work well with Flink IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda185864d561d65911922f2a687ee16ca383d85 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong removed a comment on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong removed a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902362250
> @swuferhong I see you have removed `setDefaults`. Don't we need that functionality to set the default values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902100376
ReflectionUtils.getClass() is used in many places in general.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902096475
@swuferhong I see you have removed `setDefaults`. Don't we need that functionality to set the default values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong closed pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong closed pull request #3505:
URL: https://github.com/apache/hudi/pull/3505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong closed pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong closed pull request #3505:
URL: https://github.com/apache/hudi/pull/3505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nsivabalan commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
nsivabalan commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902327023
@swuferhong @danny0405 @leesf : Trying to gauge the impact of this patch. sorry, I don't fully understand the patch yet from my quick skim thru.
We are working towards 2nd RC candidate. Can someone summarize what could happen if not for this patch. Is this something that effects core flow in hudi and does it affect all engines as well? in other words, is there a need to port this to the release branch (hot fix) ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902383784
Thanks @vinothchandar and @nsivabalan for the patience, this is a blocker for release 0.9 in my opinion.
> ReflectionUtils.getClass() is used in many places in general.
That is a bad news !!! It is risky to have wide range of use for the reflection, i have already fired 2 fix:
1. https://github.com/apache/hudi/commit/ab2e0d0ba2697ba0750ec52fbb3b3a0187734a4b
The reflection is not even thread safe for the underneath cache, a synchronized lock did solve the problem
2. https://github.com/apache/hudi/commit/b7a0d76fc99144fc2eb223cda62ac9d67528c6a2
The issue is actually caused by the ClassLoader, even though the `#setDefaults` is executed, if the `CACHED` class object comes from a different classloader, an NPE still throws.
And this patch is intended to remove the `#setDefaults` from the configurations. In any case, there is no reason/not necessary to have wide range of use for the reflection for static configurations (comes from the static members). Any one can new the config from any thread and classloaders and the reflection `CACHE` does not really solve the conflicts.
While this patch only fixes the cofiguration problem, there is risk for other code if the classloader changes unless HUDI supports explicit classloader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902393044
Removing `setDefaults()` mean, that the default values are never loaded into the property maps in these classes. So this patch as-is cannot be landed. My understanding on Spark is that all the hudi classes will get loaded onto a class loader that is accessible to the tasks. So I have not seen this issue here. the NPE due to lack of synchronization is legit though,
@nsivabalan did you run tests with spark.executor.cores > 1 in any of the runs. Do you know if we are safe there
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1840)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong closed pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong closed pull request #3505:
URL: https://github.com/apache/hudi/pull/3505
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839",
"triggerID" : "902597944",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838) Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1839)
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] swuferhong commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
swuferhong commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902362250
> @swuferhong I see you have removed `setDefaults`. Don't we need that functionality to set the default values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
} ]
}-->
## CI report:
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838)
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda185864d561d65911922f2a687ee16ca383d85 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #3505: [HUDI-2321] Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-902407336
> that the default values are never loaded into the property maps in these classes
Why the default values must be loaded into the property maps, the `ConfigProperty` did have a default value and IMO it is the only truth for default value.
The current configuration does not have a good design, such as the `HoodiePayloadProps` and `HoodiePayloadConfiguraion`, `LockConfiguration` and `HoodieLockConfig`. There are so many duplicate keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835",
"triggerID" : "902534404",
"triggerType" : "MANUAL"
}, {
"hash" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838",
"triggerID" : "91af367a1ac40311f01cb233c2694c8dccf78119",
"triggerType" : "PUSH"
}, {
"hash" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f9869c5e1ea03208ae71ff63abe0bf1391430e6c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834) Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1835)
* 91af367a1ac40311f01cb233c2694c8dccf78119 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1838)
* f9869c5e1ea03208ae71ff63abe0bf1391430e6c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot edited a comment on pull request #3505: [WIP] Don't merge. Fix ClassLoader error due to HoodieConfig$setDefaults() m…
Posted by GitBox <gi...@apache.org>.
hudi-bot edited a comment on pull request #3505:
URL: https://github.com/apache/hudi/pull/3505#issuecomment-901931018
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "eda185864d561d65911922f2a687ee16ca383d85",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814",
"triggerID" : "eda185864d561d65911922f2a687ee16ca383d85",
"triggerType" : "PUSH"
}, {
"hash" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834",
"triggerID" : "65735dfeca1b809b5dfb00e7df93694338e7fdb0",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* eda185864d561d65911922f2a687ee16ca383d85 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1814)
* 65735dfeca1b809b5dfb00e7df93694338e7fdb0 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=1834)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run travis` re-run the last Travis build
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org