[jira] (GROOVY-7407) Compilation not thread safe if Grape / Ivy is used in Groovy scripts

["Basil Crow (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/GROOVY-7407 ]


    Basil Crow deleted comment on GROOVY-7407:
    ------------------------------------

was (Author: basil):
The tested workaround delivered to Jenkins users in [https://github.com/jenkinsci/pipeline-groovy-lib-plugin/pull/148] can be fixed properly upstream by adding {{<caches lockStrategy="artifact-lock-nio" />}} below [https://github.com/apache/groovy/blob/de5ff81e020b25289c2eba8f245d46118e3c799f/src/resources/groovy/grape/defaultGrapeConfig.xml#L22] in Groovy's {{{}defaultGrapeConfig.xml{}}}.

> Compilation not thread safe if Grape / Ivy is used in Groovy scripts
> --------------------------------------------------------------------
>
>                 Key: GROOVY-7407
>                 URL: https://issues.apache.org/jira/browse/GROOVY-7407
>             Project: Groovy
>          Issue Type: Bug
>          Components: Compiler, Grape
>    Affects Versions: 2.4.3
>         Environment: Essentially independent of the environment, as long as Groovy scripts use Grape; also this bug seems to be present since at least Groovy 1.7.5.
>            Reporter: Jex Jexler
>            Priority: Minor
>              Labels: Compile, Grape, Groovy, Ivy
>         Attachments: GROOVY-7407-Jenkins-Pipeline.txt, GrabConcurrencyTest.java, GrapeAndGroovyShellConcurrencyTest.java, GroovyCompileConcurrencyTest.java, WorkaroundGroovy7407WrappingGrapeEngine.java, stacktrace-GrapeAndGroovyShellConcurrencyTest-1.txt, stacktrace-GrapeAndGroovyShellConcurrencyTest-2.txt, stacktrace-GroovyCompileConcurrencyTest-1.txt, stacktrace-GroovyCompileConcurrencyTest-2.txt
>
>
> If Groovy scripts that import the same libraries via Grape are compiled in separate threads, compilation may fail due to race conditions.
> This does not happen if several threads use the *same* instance of GroovyClassLoader (GCL), because parseClass() uses synchronization.
> But as soon as different GCLs are used in separate threads or if the compiler is used directly (CompilationUnit.compile()), the issue occurs and compilation can fail.
> Two Java unit tests have be attached, which reproduce the issue, although this cannot be guaranteed with 100% certainty, because there is a race condition.
> Two different stacktraces have been observed for each unit test (with origins in Grape and in Ivy), which have also been attached (plus in a different environment (Tomcat webapp CentOS) once a an exception down in Ivy had been observed that seemed to be related to unzipping a JAR file, but no precise record of that exists any more).



--
This message was sent by Atlassian Jira
(v8.20.10#820010)