You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/13 11:31:54 UTC
[GitHub] [nuttx] jlaitine opened a new pull request, #8107: Fix build warnings
jlaitine opened a new pull request, #8107:
URL: https://github.com/apache/nuttx/pull/8107
This is a collection of build warning fixes, which make build fail if -Werror is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko commented on a diff in pull request #8107: Fix build warnings
Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on code in PR #8107:
URL: https://github.com/apache/nuttx/pull/8107#discussion_r1069297582
##########
drivers/eeprom/i2c_xx24xx.c:
##########
@@ -472,7 +472,7 @@ static off_t ee24xx_seek(FAR struct file *filep, off_t offset, int whence)
{
filep->f_pos = newpos;
ret = newpos;
- finfo("SEEK newpos %d\n", newpos);
+ finfo("SEEK newpos %ld\n", (long)newpos);
Review Comment:
I think we have `PRIdOFF`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jlaitine commented on a diff in pull request #8107: Fix build warnings
Posted by GitBox <gi...@apache.org>.
jlaitine commented on code in PR #8107:
URL: https://github.com/apache/nuttx/pull/8107#discussion_r1069476037
##########
drivers/eeprom/i2c_xx24xx.c:
##########
@@ -472,7 +472,7 @@ static off_t ee24xx_seek(FAR struct file *filep, off_t offset, int whence)
{
filep->f_pos = newpos;
ret = newpos;
- finfo("SEEK newpos %d\n", newpos);
+ finfo("SEEK newpos %ld\n", (long)newpos);
Review Comment:
Yes. I included inttypes.h and used PRIdOFF for off_t and %zu for size_t
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 merged pull request #8107: Fix build warnings
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged PR #8107:
URL: https://github.com/apache/nuttx/pull/8107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org