You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@superset.apache.org by en...@apache.org on 2025/06/25 08:33:53 UTC
(superset) branch enxdev/fix/visual-regression-p6 created (now 0a4f7ddd03)
This is an automated email from the ASF dual-hosted git repository.
enzomartellucci pushed a change to branch enxdev/fix/visual-regression-p6
in repository https://gitbox.apache.org/repos/asf/superset.git
at 0a4f7ddd03 fix(style): resolve some visual regressions
This branch includes the following new commits:
new 0a4f7ddd03 fix(style): resolve some visual regressions
The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
(superset) 01/01: fix(style): resolve some visual regressions
Posted by en...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
enzomartellucci pushed a commit to branch enxdev/fix/visual-regression-p6
in repository https://gitbox.apache.org/repos/asf/superset.git
commit 0a4f7ddd0351871514fc85040085c92d3b91b923
Author: Enzo Martellucci <en...@gmail.com>
AuthorDate: Wed Jun 25 10:26:49 2025 +0200
fix(style): resolve some visual regressions
---
.../superset-ui-core/src/components/FaveStar/index.tsx | 2 +-
.../src/components/MetadataBar/MetadataBar.tsx | 10 ++++++++--
superset-frontend/src/dashboard/components/Header/index.jsx | 7 +------
.../src/explore/components/controls/TextAreaControl.jsx | 7 ++++++-
superset-frontend/src/pages/DatasetList/index.tsx | 2 +-
5 files changed, 17 insertions(+), 11 deletions(-)
diff --git a/superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx b/superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx
index bd51fa2a2c..7558a55893 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/FaveStar/index.tsx
@@ -71,7 +71,7 @@ export const FaveStar = ({
<Icons.StarOutlined
aria-label="unstarred"
iconSize="l"
- iconColor={theme.colors.grayscale.light1}
+ iconColor={theme.colorTextTertiary}
name="favorite-unselected"
/>
)}
diff --git a/superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx b/superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx
index 7820f0757e..1be1817e26 100644
--- a/superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx
+++ b/superset-frontend/packages/superset-ui-core/src/components/MetadataBar/MetadataBar.tsx
@@ -19,7 +19,7 @@
import { useCallback, useEffect, useRef, useState } from 'react';
import { useResizeDetector } from 'react-resize-detector';
import { uniqWith } from 'lodash';
-import { styled } from '@superset-ui/core';
+import { styled, useTheme } from '@superset-ui/core';
import { Tooltip } from '../Tooltip';
import { TooltipPlacement } from '../Tooltip/types';
import { ContentType } from './ContentType';
@@ -132,6 +132,8 @@ const Item = ({
);
}, [barWidth, setIsTruncated, contentType]);
+ const theme = useTheme();
+
const content = (
<StyledItem
collapsed={collapsed}
@@ -139,7 +141,11 @@ const Item = ({
onClick={onClick ? () => onClick(type) : undefined}
role={onClick ? 'button' : undefined}
>
- <Icon iconSize="l" className="metadata-icon" />
+ <Icon
+ iconSize="l"
+ iconColor={theme.colorTextTertiary}
+ className="metadata-icon"
+ />
{!collapsed && (
<span ref={ref} className="metadata-text">
{title}
diff --git a/superset-frontend/src/dashboard/components/Header/index.jsx b/superset-frontend/src/dashboard/components/Header/index.jsx
index b980759f1a..b677a8c5ec 100644
--- a/superset-frontend/src/dashboard/components/Header/index.jsx
+++ b/superset-frontend/src/dashboard/components/Header/index.jsx
@@ -26,7 +26,6 @@ import {
FeatureFlag,
t,
getExtensionsRegistry,
- useTheme,
} from '@superset-ui/core';
import { Global } from '@emotion/react';
import { shallowEqual, useDispatch, useSelector } from 'react-redux';
@@ -159,7 +158,6 @@ const discardChanges = () => {
};
const Header = () => {
- const theme = useTheme();
const dispatch = useDispatch();
const [didNotifyMaxUndoHistoryToast, setDidNotifyMaxUndoHistoryToast] =
useState(false);
@@ -650,10 +648,7 @@ const Header = () => {
data-test="header-save-button"
aria-label={t('Save')}
>
- <Icons.SaveOutlined
- iconColor={hasUnsavedChanges && theme.colors.primary.light5}
- iconSize="m"
- />
+ <Icons.SaveOutlined iconSize="m" />
{t('Save')}
</Button>
</div>
diff --git a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx
index e3a65c5e3b..9089b5c700 100644
--- a/superset-frontend/src/explore/components/controls/TextAreaControl.jsx
+++ b/superset-frontend/src/explore/components/controls/TextAreaControl.jsx
@@ -25,7 +25,7 @@ import {
TextAreaEditor,
ModalTrigger,
} from '@superset-ui/core/components';
-import { t, withTheme } from '@superset-ui/core';
+import { t, withTheme, css } from '@superset-ui/core';
import ControlHeader from 'src/explore/components/ControlHeader';
@@ -112,6 +112,11 @@ class TextAreaControl extends Component {
const codeEditor = (
<div>
<TextAreaEditor
+ css={css`
+ .ace_gutter-active-line {
+ background-color: inherit;
+ }
+ `}
mode={this.props.language}
style={style}
minLines={minLines}
diff --git a/superset-frontend/src/pages/DatasetList/index.tsx b/superset-frontend/src/pages/DatasetList/index.tsx
index 6ef48d2f48..6ae0495ca2 100644
--- a/superset-frontend/src/pages/DatasetList/index.tsx
+++ b/superset-frontend/src/pages/DatasetList/index.tsx
@@ -468,7 +468,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
'You must be a dataset owner in order to edit. Please reach out to a dataset owner to request modifications or edit access.',
)
}
- placement="bottomRight"
+ placement="bottom"
>
<span
role="button"