You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org> on 2026/09/19 14:35:51 UTC
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Csaba Ringhofer has uploaded this change for review. ( http://gerrit.cloudera.org:8080/24897
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
IMPALA-15383: Fix download-impala-jdbc-driver.sh
It seems that the structure of the zip was changed.
Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
---
M testdata/bin/download-impala-jdbc-driver.sh
1 file changed, 1 insertion(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/97/24897/1
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24897 )
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/24105/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2026 15:00:34 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has abandoned this change. ( http://gerrit.cloudera.org:8080/24897 )
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
Abandoned
abandoning this as https://gerrit.cloudera.org/#/c/24898/ solved the problem
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24897 )
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
Patch Set 1:
(1 comment)
gerrit-auto-critic failed. You can reproduce it locally using command:
python3 bin/jenkins/critique-gerrit-review.py --dryrun
To run it, you might need a virtual env with Python3's venv installed.
http://gerrit.cloudera.org:8080/#/c/24897/1/testdata/bin/download-impala-jdbc-driver.sh
File testdata/bin/download-impala-jdbc-driver.sh:
http://gerrit.cloudera.org:8080/#/c/24897/1/testdata/bin/download-impala-jdbc-driver.sh@61
PS1, Line 61: hadoop fs -put -f /tmp/impala_jdbc_driver/${SIMBA_DRIVER_ZIP_FILENAME}/${SIMBA_DRIVER_JAR_FILENAME} \
line too long (101 > 90)
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2026 14:38:32 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24897 )
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
Patch Set 1:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/14091/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2026 14:36:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-15383: Fix download-impala-jdbc-driver.sh
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24897 )
Change subject: IMPALA-15383: Fix download-impala-jdbc-driver.sh
......................................................................
Patch Set 1: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/24897
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I67fb5b9661b51287a59f0fb3a1acf81beef58f49
Gerrit-Change-Number: 24897
Gerrit-PatchSet: 1
Gerrit-Owner: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 19 Sep 2026 19:06:09 +0000
Gerrit-HasComments: No