You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/10/06 03:33:49 UTC

[GitHub] [spark] HyukjinKwon opened a new pull request, #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

HyukjinKwon opened a new pull request, #38118:
URL: https://github.com/apache/spark/pull/38118

   ### What changes were proposed in this pull request?
   
   This PR reenable MyPy tests in Spark Connect tests.
   
   ### Why are the changes needed?
   
   To keep the MyPy rules consistent in PySpark codebase.
   
   ### Does this PR introduce _any_ user-facing change?
   
   No, test-only
   
   ### How was this patch tested?
   
   CI in this PR should test it out.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38118:
URL: https://github.com/apache/spark/pull/38118#issuecomment-1269375544

   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] zhengruifeng commented on pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #38118:
URL: https://github.com/apache/spark/pull/38118#issuecomment-1269376924

   LGTM +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] amaliujia commented on pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

Posted by GitBox <gi...@apache.org>.
amaliujia commented on PR #38118:
URL: https://github.com/apache/spark/pull/38118#issuecomment-1269301080

   LGTM


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests
URL: https://github.com/apache/spark/pull/38118


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #38118: [SPARK-40537][CONNECT][PYTHON] Reenable MyPy in Spark Connect Python tests

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #38118:
URL: https://github.com/apache/spark/pull/38118#issuecomment-1269275765

   cc @amaliujia @itholic @ueshin @xinrong-meng @zhengruifeng if you find some time to review.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org