You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2014/12/29 14:39:23 UTC
Review Request 29455: LENS-162: ranges can be configured via xml
(changes to prevent documentation from breaking)
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29455/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-162
https://issues.apache.org/jira/browse/LENS-162
Repository: lens
Description
-------
config and config generator changes
Diffs
-----
lens-api/src/test/java/org/apache/lens/doc/TestGenerateConfigDoc.java d331c73ce88a08a5d7ae54874069515e80e7659e
lens-driver-hive/src/main/resources/hivedriver-default.xml 3b9eaaea5e9d0f915949a33260cfcb2a70721ee8
src/site/apt/admin/config.apt e982b07fd17f0b1be28ed183ec4c891a97a19ae9
src/site/apt/admin/hivedriver-config.apt f59faaba83cde7dc2cf81353f2cd0d53867f0c20
src/site/apt/admin/jdbcdriver-config.apt 426d6eb8eeebc3320ecedf3f6597e928f6291733
src/site/apt/admin/session-config.apt af4cc81793babf2c6d01c20071c7839e23680bb3
src/site/apt/user/client-config.apt 9dd1e3db1ed9abc377fe5c7bd884526e082a1c00
src/site/apt/user/olap-query-conf.apt f10313fd78218d22a503ff3787c2741c58aa2fd3
Diff: https://reviews.apache.org/r/29455/diff/
Testing
-------
Thanks,
Rajat Khandelwal
Re: Review Request 29455: LENS-162: ranges can be configured via xml
(changes to prevent documentation from breaking)
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29455/#review66275
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 29, 2014, 1:48 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29455/
> -----------------------------------------------------------
>
> (Updated Dec. 29, 2014, 1:48 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-162
> https://issues.apache.org/jira/browse/LENS-162
>
>
> Repository: lens
>
>
> Description
> -------
>
> config and config generator changes
>
>
> Diffs
> -----
>
> lens-api/src/test/java/org/apache/lens/doc/TestGenerateConfigDoc.java d331c73ce88a08a5d7ae54874069515e80e7659e
> lens-driver-hive/src/main/resources/hivedriver-default.xml 33ae8603b73b9f745f562fb8efc98669618fe03a
> src/site/apt/admin/config.apt e982b07fd17f0b1be28ed183ec4c891a97a19ae9
> src/site/apt/admin/hivedriver-config.apt 576025e60a7ecff02e0682f308584a97e22e5f2b
> src/site/apt/admin/jdbcdriver-config.apt 426d6eb8eeebc3320ecedf3f6597e928f6291733
> src/site/apt/admin/session-config.apt af4cc81793babf2c6d01c20071c7839e23680bb3
> src/site/apt/user/olap-query-conf.apt f10313fd78218d22a503ff3787c2741c58aa2fd3
>
> Diff: https://reviews.apache.org/r/29455/diff/
>
>
> Testing
> -------
>
> This is how the priority section looks:
> ```
> Priority Ranges. The numbers are the costs of the query.
> The cost is calculated based on partition weights and fact weights. The interpretation of the default config is:
>
> cost <= 7 : Priority = VERY_HIGH
> 7 < cost <= 30 : Priority = HIGH
> 30 < cost <= 90 : Priority = NORMAL
> 90 < cost : Priority = LOW
>
> Some perspective wrt default weights and default ranges(1 for hourly, 0.75 for daily, 0.5 for monthly):
> For exclusively hourly data this translates to VERY_HIGH,7days,HIGH,30days,NORMAL,90days,LOW.
> FOR exclusively daily data this translates to VERY_HIGH,9days,HIGH,40days,NORMAL,120days,LOW.
> for exclusively monthly data this translates to VERY_HIGH,never,HIGH,1month,NORMAL,6months,LOW.
>
> One use case in range tuning can be that you never want queries to run with VERY_HIGH, assuming no other changes, you'll modify the value of this param in hivedriver-site.xml to be HIGH,30.0,NORMAL,90,LOW
> via the configs, you can tune both the ranges and partition weights. this would give the end user more control.
> ```
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 29455: LENS-162: ranges can be configured via xml
(changes to prevent documentation from breaking)
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29455/
-----------------------------------------------------------
(Updated Dec. 29, 2014, 1:48 p.m.)
Review request for lens.
Bugs: LENS-162
https://issues.apache.org/jira/browse/LENS-162
Repository: lens
Description
-------
config and config generator changes
Diffs (updated)
-----
lens-api/src/test/java/org/apache/lens/doc/TestGenerateConfigDoc.java d331c73ce88a08a5d7ae54874069515e80e7659e
lens-driver-hive/src/main/resources/hivedriver-default.xml 33ae8603b73b9f745f562fb8efc98669618fe03a
src/site/apt/admin/config.apt e982b07fd17f0b1be28ed183ec4c891a97a19ae9
src/site/apt/admin/hivedriver-config.apt 576025e60a7ecff02e0682f308584a97e22e5f2b
src/site/apt/admin/jdbcdriver-config.apt 426d6eb8eeebc3320ecedf3f6597e928f6291733
src/site/apt/admin/session-config.apt af4cc81793babf2c6d01c20071c7839e23680bb3
src/site/apt/user/olap-query-conf.apt f10313fd78218d22a503ff3787c2741c58aa2fd3
Diff: https://reviews.apache.org/r/29455/diff/
Testing (updated)
-------
This is how the priority section looks:
```
Priority Ranges. The numbers are the costs of the query.
The cost is calculated based on partition weights and fact weights. The interpretation of the default config is:
cost <= 7 : Priority = VERY_HIGH
7 < cost <= 30 : Priority = HIGH
30 < cost <= 90 : Priority = NORMAL
90 < cost : Priority = LOW
Some perspective wrt default weights and default ranges(1 for hourly, 0.75 for daily, 0.5 for monthly):
For exclusively hourly data this translates to VERY_HIGH,7days,HIGH,30days,NORMAL,90days,LOW.
FOR exclusively daily data this translates to VERY_HIGH,9days,HIGH,40days,NORMAL,120days,LOW.
for exclusively monthly data this translates to VERY_HIGH,never,HIGH,1month,NORMAL,6months,LOW.
One use case in range tuning can be that you never want queries to run with VERY_HIGH, assuming no other changes, you'll modify the value of this param in hivedriver-site.xml to be HIGH,30.0,NORMAL,90,LOW
via the configs, you can tune both the ranges and partition weights. this would give the end user more control.
```
Thanks,
Rajat Khandelwal