You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@plc4x.apache.org by sr...@apache.org on 2022/07/22 09:22:38 UTC

[plc4x] branch develop updated: test(cbus): enabled tests again

This is an automated email from the ASF dual-hosted git repository.

sruehl pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/plc4x.git


The following commit(s) were added to refs/heads/develop by this push:
     new 644040737 test(cbus): enabled tests again
644040737 is described below

commit 64404073775f6e8dd1afe5059132855f487093ed
Author: Sebastian Rühl <sr...@apache.org>
AuthorDate: Fri Jul 22 11:22:32 2022 +0200

    test(cbus): enabled tests again
    
    - root cause: wrong ramp level selected
---
 .../src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java     | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java b/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java
index 1d6f9ffcf..fc5deb8b3 100644
--- a/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java
+++ b/plc4j/drivers/c-bus/src/test/java/org/apache/plc4x/java/cbus/ReferenceTest.java
@@ -825,11 +825,10 @@ public class ReferenceTest {
                 System.out.println(((ReplyEncodedReply) ((ReplyOrConfirmationReply) ((CBusMessageToClient) msg).getReply()).getReply()).getEncodedReply());
             }
 
-            @Disabled("TODO: apparently this message is not fully parseable so either correct the package or find the bug") // TODO: fix the bug
             // 7.3
             @Test
             void ReceiveAnRampToLevelCommand() throws Exception {
-                byte[] bytes = "0500380055085511\r\n".getBytes(StandardCharsets.UTF_8);
+                byte[] bytes = "050038005A08550C\r\n".getBytes(StandardCharsets.UTF_8);
                 ReadBufferByteBased readBufferByteBased = new ReadBufferByteBased(bytes);
                 cBusOptions = new CBusOptions(false, false, false, false, false, false, false, false, true);
                 CBusMessage msg = CBusMessage.staticParse(readBufferByteBased, true, requestContext, cBusOptions, bytes.length);
@@ -838,11 +837,10 @@ public class ReferenceTest {
                 System.out.println(((ReplyEncodedReply) ((ReplyOrConfirmationReply) ((CBusMessageToClient) msg).getReply()).getReply()).getEncodedReply());
             }
 
-            @Disabled("TODO: apparently this message is not fully parseable so either correct the package or find the bug") // TODO: fix the bug
             // 7.3
             @Test
             void ReceiveAnRampToLevelCommandAlternative() throws Exception {
-                byte[] bytes = "050038010055085510\r\n".getBytes(StandardCharsets.UTF_8);
+                byte[] bytes = "05003801005A08550B\r\n".getBytes(StandardCharsets.UTF_8);
                 ReadBufferByteBased readBufferByteBased = new ReadBufferByteBased(bytes);
                 cBusOptions = new CBusOptions(false, false, false, false, false, false, false, false, true);
                 CBusMessage msg = CBusMessage.staticParse(readBufferByteBased, true, requestContext, cBusOptions, bytes.length);