You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/19 05:49:07 UTC
[GitHub] [doris] Gabriel39 opened a new pull request, #11913: [Bug](shell) fix wrong condition expression in script
Gabriel39 opened a new pull request, #11913:
URL: https://github.com/apache/doris/pull/11913
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11913:
URL: https://github.com/apache/doris/pull/11913#issuecomment-1220296788
Would you like to provide some steps to reproduce the issue? I ran `bash -x run-regression-test.sh` on my machine but found the condition passed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] Gabriel39 commented on pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
Gabriel39 commented on PR #11913:
URL: https://github.com/apache/doris/pull/11913#issuecomment-1220283046
cc @adonis0147 this condition always return false now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #11913:
URL: https://github.com/apache/doris/pull/11913#discussion_r949848930
##########
run-regression-test.sh:
##########
@@ -141,7 +141,7 @@ if [[ "${RUN}" -ne 1 ]]; then
exit 0
fi
-if [[ ! -f ${RUN_JAR} ]]; then
+if [ ! -f ${RUN_JAR} ]; then
Review Comment:
Please change to this to pass the `shellcheck`.
```suggestion
if ! test -f ${RUN_JAR:+${RUN_JAR}}; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #11913:
URL: https://github.com/apache/doris/pull/11913#issuecomment-1220311172
Finally, I got the issue which the pr aims at resolving.
When we run `run-regression-test.sh`, the script always build the jar for regression test framework even if the jar was built before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11913:
URL: https://github.com/apache/doris/pull/11913#issuecomment-1220516224
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11913:
URL: https://github.com/apache/doris/pull/11913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on a diff in pull request #11913: [Bug](shell) fix wrong condition expression in script
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on code in PR #11913:
URL: https://github.com/apache/doris/pull/11913#discussion_r949848930
##########
run-regression-test.sh:
##########
@@ -141,7 +141,7 @@ if [[ "${RUN}" -ne 1 ]]; then
exit 0
fi
-if [[ ! -f ${RUN_JAR} ]]; then
+if [ ! -f ${RUN_JAR} ]; then
Review Comment:
Please change it to this to pass the `shellcheck`.
```suggestion
if ! test -f ${RUN_JAR:+${RUN_JAR}}; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org