You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "pan3793 (via GitHub)" <gi...@apache.org> on 2023/07/18 15:23:44 UTC
[GitHub] [incubator-celeborn] pan3793 commented on a diff in pull request #1730: [CELEBORN-807] Adjust shutdown worker logs in LifecycleManager
pan3793 commented on code in PR #1730:
URL: https://github.com/apache/incubator-celeborn/pull/1730#discussion_r1266940412
##########
client/src/main/scala/org/apache/celeborn/client/WorkerStatusTracker.scala:
##########
@@ -198,10 +207,11 @@ class WorkerStatusTracker(
}
}
}
-
- logInfo(
- s"Current excluded workers $excludedWorkers, Current shuttingDown ${shuttingWorkers.asScala.map(
- _.readableAddress()).mkString("\n")}")
+ if (statusChanged) {
+ logInfo(
+ s"Current excluded workers $excludedWorkers, " +
+ s"Current shutting down workers ${shuttingWorkers.asScala.map(_.readableAddress()).mkString("\n")}")
Review Comment:
how about the following? (I write it by hand you may need to call `dev/reformat`)
```suggestion
logInfo(
s"""
|Current excluded workers:
|$excludedWorkers.mkString("\n")
|
|Current shutting down workers:
|${shuttingWorkers.asScala.map(_.readableAddress()).mkString("\n")}"
|"""stripMargin)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org