You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/20 08:13:48 UTC

[GitHub] [spark] HeartSaVioR edited a comment on issue #24154: [SPARK-27210][SS] Cleanup incomplete output files in ManifestFileCommitProtocol if task is aborted

HeartSaVioR edited a comment on issue #24154: [SPARK-27210][SS] Cleanup incomplete output files in ManifestFileCommitProtocol if task is aborted
URL: https://github.com/apache/spark/pull/24154#issuecomment-474729281
 
 
   We might also try to clean up for complete tasks as well, via letting ManifestFileCommitProtocol records output files for committed tasks (via `onTaskCommit`), and try to delete these files when `abortJob` is called. This approach has clear requirement: the filesystem for output directory must be same across driver and tasks. Not sure there's some case which breaks this - local FS output directory with distributed executors might be though honestly it doesn't make sense for actual case.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org