You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/09/02 05:15:24 UTC

[GitHub] [airflow] kushsharma opened a new pull request #10685: Trim logs before going to sleep

kushsharma opened a new pull request #10685:
URL: https://github.com/apache/airflow/pull/10685


   If the pod restarts before the sleep time is over, the trim command will not run. I think it's better if we reorder the commands to execute the delete and then go to sleep. At the moment sleep is every 15 mins but people will just increase the EVERY line if they want longer sleep time and can encounter this bug.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kushsharma commented on pull request #10685: scripts: should trim logs before going to sleep

Posted by GitBox <gi...@apache.org>.
kushsharma commented on pull request #10685:
URL: https://github.com/apache/airflow/pull/10685#issuecomment-687622891


   @XD-DENG Hi, I have updated the same as requested. I am not sure if this is more helpful, please let me know if you have anything else in mind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on pull request #10685: scripts: should trim logs before going to sleep

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #10685:
URL: https://github.com/apache/airflow/pull/10685#issuecomment-687627165


   Awesome work, congrats on your first merged pull request!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] XD-DENG merged pull request #10685: scripts: should trim logs before going to sleep

Posted by GitBox <gi...@apache.org>.
XD-DENG merged pull request #10685:
URL: https://github.com/apache/airflow/pull/10685


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] XD-DENG commented on pull request #10685: scripts: should trim logs before going to sleep

Posted by GitBox <gi...@apache.org>.
XD-DENG commented on pull request #10685:
URL: https://github.com/apache/airflow/pull/10685#issuecomment-687627199


   Thanks @kushsharma . I further updated the subject a little bit, hope you don't mind.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org