You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Joshua Cohen <jc...@twopensource.com> on 2015/01/16 22:45:25 UTC
Review Request 29984: Minor clean up to mock usage in resource manager
integration tests.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/
-----------------------------------------------------------
Review request for Aurora, Kevin Sweeney and Brian Wickman.
Repository: aurora
Description
-------
Minor clean up to mock usage in resource manager integration tests.
We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
Diffs
-----
src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
Diff: https://reviews.apache.org/r/29984/diff/
Testing
-------
./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
Thanks,
Joshua Cohen
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68754
-----------------------------------------------------------
@ReviewBoy retry
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68829
-----------------------------------------------------------
@ReviewBot retry
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Brian Wickman <wi...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68961
-----------------------------------------------------------
Ship it!
Ship It!
- Brian Wickman
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68828
-----------------------------------------------------------
*ping*
- Joshua Cohen
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68479
-----------------------------------------------------------
Master (1346c4f) is red with this patch.
./build-support/jenkins/build.sh
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdMain
:test
:jacocoTestReport
Coverage report generated: file:///x1/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.8929194773338365 exceeds minimum coverage of 0.89.
Branch coverage of 0.8393782383419689 exceeds minimum coverage of 0.835.
:check
:build
:api:assemble
:api:compileTestJava UP-TO-DATE
:api:processTestResources UP-TO-DATE
:api:testClasses UP-TO-DATE
:api:test UP-TO-DATE
:api:check UP-TO-DATE
:api:build
:buildSrc:compileJava UP-TO-DATE
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes UP-TO-DATE
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
BUILD SUCCESSFUL
Total time: 2 mins 57.371 secs
+ export PIP_DEFAULT_TIMEOUT=60
+ PIP_DEFAULT_TIMEOUT=60
+ mkdir -p third_party
+ pip install -d third_party -r /dev/fd/63
++ grep -v mesos.native 3rdparty/python/requirements.txt
./build-support/jenkins/build.sh: line 28: pip: command not found
grep: write error: Broken pipe
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>
Re: Review Request 29984: Minor clean up to mock usage in resource
manager integration tests.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29984/#review68836
-----------------------------------------------------------
Ship it!
Master (116ee2d) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Jan. 16, 2015, 9:45 p.m., Joshua Cohen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29984/
> -----------------------------------------------------------
>
> (Updated Jan. 16, 2015, 9:45 p.m.)
>
>
> Review request for Aurora, Kevin Sweeney and Brian Wickman.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Minor clean up to mock usage in resource manager integration tests.
>
> We didn't need to wrap the mock disk collector in a lambda, just rather than asserting on the mock class, we instead needed to assert on its return value (the instance).
>
>
> Diffs
> -----
>
> src/test/python/apache/aurora/executor/common/test_resource_manager_integration.py bb3045700c2870329e175db44873dcb990226c7a
>
> Diff: https://reviews.apache.org/r/29984/diff/
>
>
> Testing
> -------
>
> ./pants build src/test/python/apache/aurora/executor/common:resource_manager_integration
>
>
> Thanks,
>
> Joshua Cohen
>
>