You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "TyrantLucifer (via GitHub)" <gi...@apache.org> on 2023/07/28 11:13:35 UTC

[GitHub] [seatunnel] TyrantLucifer commented on a diff in pull request #5153: [Feature][Connector V2][File] Add config of 'file_filter_pattern', which used for filtering files.

TyrantLucifer commented on code in PR #5153:
URL: https://github.com/apache/seatunnel/pull/5153#discussion_r1277418600


##########
seatunnel-connectors-v2/connector-file/connector-file-base/src/main/java/org/apache/seatunnel/connectors/seatunnel/file/config/BaseSourceConfig.java:
##########
@@ -112,4 +112,11 @@ public class BaseSourceConfig {
                     .stringType()
                     .noDefaultValue()
                     .withDescription("To be read sheet name,only valid for excel files");
+
+    public static final Option<String> FILE_FILTER_PATTERN =
+            Options.key("file_filter_pattern")
+                    .stringType()
+                    .defaultValue("*")

Review Comment:
   +1, agree with @hailin0 , this is an optional parameter, should do nothing when this parameter is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org