You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@spamassassin.apache.org on 2022/04/18 04:08:28 UTC

[Bug 7972] New: Version compatibility flagging method

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7972

            Bug ID: 7972
           Summary: Version compatibility flagging method
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P2
         Component: Libraries
          Assignee: dev@spamassassin.apache.org
          Reporter: apache@hege.li
  Target Milestone: Undefined

(Copy from Bug 7826)

Assuming we want to go with the welcomelist route, I'd still like to figure out
a more generic solution for defining "version compatibility". So people can
turn on some flag when they have checked their local configs and removed old
incompatibilities, so old duplicate USER_IN_BLACKLIST rules stop beeing seen. A
bit like postfix "compatibility_level".

Previous solution was loading/unloading module and "ifplugin
Mail::SpamAssassin::Plugin::RaciallyCharged". A bit awkward and way too
hardcoded.

I'm visioning something like "enable_compat welcomelist_blocklist" that one can
insert into init.pre. It would create
"Mail::SpamAssassin::Conf::compat_welcomelist_blacklist" function dynamically,
so we can do this check to skip rules:

if can(Mail::SpamAssassin::Conf::compat_welcomelist_blacklist)

Of course the same could be checked from plugins etc if necessary.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7972] Version compatibility flagging method

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7972

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|NEW                         |RESOLVED

--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
    enable_compat xxxxxx
        Define a version compatibility flag.

        This creates a function named
"Mail::SpamAssassin::Conf::compat_xxxxxx", which returns true. It can be used
for example in cf-files, similarly as existing "feature_" checks:

          if can(Mail::SpamAssassin::Conf::compat_xxxxxx)

        Name can only consist of [a-zA-Z0-9_] characters.

        Mainly used by SpamAssassin distribution to handle backwards
compatibility issues.


Sending        trunk/MANIFEST
Sending        trunk/lib/Mail/SpamAssassin/Conf.pm
Adding         trunk/t/enable_compat.t
Transmitting file data ...done
Committing transaction...
Committed revision 1899984.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7972] Version compatibility flagging method

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7972

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Target Milestone|Undefined                   |4.0.0
                 CC|                            |apache@hege.li

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7972] Version compatibility flagging method

Posted by bu...@spamassassin.apache.org.
https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7972

--- Comment #1 from Henrik Krohns <ap...@hege.li> ---
And in this case I assume we would want to include it by default in distributed
init.pre, so fresh installations will have it, but old ones will not be
overridden.

enable_compat welcomelist_blocklist

-- 
You are receiving this mail because:
You are the assignee for the bug.