[GitHub] [calcite] wojustme commented on a change in pull request #2094: [CALCITE-3409] Add an interface in RelOptMaterializations…

[GitBox <gi...@apache.org>]

wojustme commented on a change in pull request #2094:
URL: https://github.com/apache/calcite/pull/2094#discussion_r713841077



##########
File path: core/src/main/java/org/apache/calcite/plan/RelOptMaterializations.java
##########
@@ -214,7 +232,11 @@
     hepPlanner.setRoot(root);
     root = hepPlanner.findBestExp();
 
-    return new SubstitutionVisitor(target, root).go(materialization.tableRel);
+    return new SubstitutionVisitor(target, root, ImmutableList.
+        <SubstitutionVisitor.UnifyRule>builder()
+        .addAll(materializationRules)
+        .addAll(SubstitutionVisitor.DEFAULT_RULES)

Review comment:
       So, Real running rules of unify is collection of SubstitutionVisitor's default and external-injected?
   Will we meet one case, which it only want work with external-injected rules, not included default?
   This case may occur, for example: we overload some `SqlAggFunction` to replace calcite default `SqlAggFunction`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org