You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/04/24 17:01:07 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request #48: Remove Ballista DataFrame
andygrove opened a new pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48
# Which issue does this PR close?
Closes https://github.com/apache/arrow-datafusion/issues/2
# Rationale for this change
One DataFrame implementation is better than two.
# What changes are included in this PR?
- Remove Ballista DataFrame
- Move Ballista collect() method to BallistaContext
# Are there any user-facing changes?
Yes, users now get DataFusion dataframes from the BallistaContext.
If there are user-facing changes then we may require documentation to be updated before approving the PR.
There isn't really any documentation yet to update.
If there are any breaking changes to public APIs, please add the `breaking change` label.
This is a breaking change but Ballista is < 1.0.0 so expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48#issuecomment-826326107
@alamb @jorgecarleitao Any objection to me merging this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove commented on pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48#issuecomment-826326107
@alamb @jorgecarleitao Any objection to me merging this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48#issuecomment-826125344
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#48](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c73c1f3) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/9ba214a52ed78c57d3d6363c61a88893d41fe906?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ba214a) will **increase** coverage by `0.11%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c73c1f3 differs from pull request most recent head 794dbce. Consider uploading reports for the commit 794dbce to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 76.24% 76.36% +0.11%
==========================================
Files 134 134
Lines 23051 23017 -34
==========================================
Hits 17576 17576
+ Misses 5475 5441 -34
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ballista/rust/client/src/context.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9jbGllbnQvc3JjL2NvbnRleHQucnM=) | `0.00% <0.00%> (ø)` | |
| [benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVuY2htYXJrcy9zcmMvYmluL3RwY2gucnM=) | `35.07% <0.00%> (-0.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ba214a...794dbce](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] andygrove merged pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
andygrove merged pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] codecov-commenter commented on pull request #48: Remove Ballista DataFrame
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #48:
URL: https://github.com/apache/arrow-datafusion/pull/48#issuecomment-826125344
# [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#48](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c73c1f3) into [master](https://codecov.io/gh/apache/arrow-datafusion/commit/9ba214a52ed78c57d3d6363c61a88893d41fe906?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9ba214a) will **increase** coverage by `0.11%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head c73c1f3 differs from pull request most recent head 794dbce. Consider uploading reports for the commit 794dbce to get more accurate results
[](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 76.24% 76.36% +0.11%
==========================================
Files 134 134
Lines 23051 23017 -34
==========================================
Hits 17576 17576
+ Misses 5475 5441 -34
```
| [Impacted Files](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [ballista/rust/client/src/context.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmFsbGlzdGEvcnVzdC9jbGllbnQvc3JjL2NvbnRleHQucnM=) | `0.00% <0.00%> (ø)` | |
| [benchmarks/src/bin/tpch.rs](https://codecov.io/gh/apache/arrow-datafusion/pull/48/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YmVuY2htYXJrcy9zcmMvYmluL3RwY2gucnM=) | `35.07% <0.00%> (-0.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9ba214a...794dbce](https://codecov.io/gh/apache/arrow-datafusion/pull/48?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org