You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@trafficserver.apache.org by persiaAziz <gi...@git.apache.org> on 2015/05/27 22:27:49 UTC
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
GitHub user persiaAziz opened a pull request:
https://github.com/apache/trafficserver/pull/204
TS-3560: Make slow log overridable.
TS-3560 : make slow_log_threshold overridable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/persiaAziz/trafficserver ts-3560
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafficserver/pull/204.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #204
----
commit 97fedd173de8a95c02984ac50a43744c9ee640d7
Author: Syeda Persia Aziz <pe...@yahoo-inc.com>
Date: 2015-05-26T21:04:57Z
TS-3560: Make slow log overridable.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz closed the pull request at:
https://github.com/apache/trafficserver/pull/204
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by persiaAziz <gi...@git.apache.org>.
Github user persiaAziz commented on the pull request:
https://github.com/apache/trafficserver/pull/204#issuecomment-106096407
Done Syeda Persia Aziz
CSE,BUET
On Wednesday, May 27, 2015 3:37 PM, Alan M. Carroll <no...@github.com> wrote:
Looks good overall but needs a bit of cleanup. In general the "// !@#" comments need to be removed.—
Reply to this email directly or view it on GitHub.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177349
--- Diff: proxy/http/HttpConfig.h ---
@@ -708,7 +708,7 @@ struct HttpConfigParams : public ConfigInfo {
// Error Reporting //
/////////////////////
MgmtByte errors_log_error_pages;
- MgmtInt slow_log_threshold;
+ //MgmtInt slow_log_threshold; !@#
--- End diff --
Remove this entirely, don't leave it commented out.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177284
--- Diff: proxy/http/HttpConfig.h ---
@@ -554,8 +554,8 @@ struct OverridableHttpConfigParams {
MgmtInt flow_low_water_mark; ///< Flow control low water mark.
MgmtInt default_buffer_size_index;
- MgmtInt default_buffer_water_mark;
-
+ MgmtInt default_buffer_water_mark;
--- End diff --
Clean up trailing whitespace.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on the pull request:
https://github.com/apache/trafficserver/pull/204#issuecomment-106066389
Looks good overall but needs a bit of cleanup. In general the "// !@#" comments need to be removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] trafficserver pull request: TS-3560: Make slow log overridable.
Posted by SolidWallOfCode <gi...@git.apache.org>.
Github user SolidWallOfCode commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/204#discussion_r31177159
--- Diff: plugins/experimental/ts_lua/ts_lua_http_config.c ---
@@ -81,7 +81,8 @@ typedef enum {
TS_LUA_CONFIG_HTTP_CACHE_FUZZ_PROBABILITY = TS_CONFIG_HTTP_CACHE_FUZZ_PROBABILITY,
TS_LUA_CONFIG_NET_SOCK_PACKET_MARK_OUT = TS_CONFIG_NET_SOCK_PACKET_MARK_OUT,
TS_LUA_CONFIG_NET_SOCK_PACKET_TOS_OUT = TS_CONFIG_NET_SOCK_PACKET_TOS_OUT,
- TS_LUA_CONFIG_LAST_ENTRY = TS_CONFIG_LAST_ENTRY
+ TS_LUA_CONFIG_LAST_ENTRY = TS_CONFIG_LAST_ENTRY,
--- End diff --
This needs to be the last entry.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---