You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@royale.apache.org by ha...@apache.org on 2019/01/01 11:16:52 UTC

[royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

This is an automated email from the ASF dual-hosted git repository.

harbs pushed a commit to branch develop
in repository https://gitbox.apache.org/repos/asf/royale-asjs.git


The following commit(s) were added to refs/heads/develop by this push:
     new ef95bb4  Changed clean script to only delete the swc files in libs
ef95bb4 is described below

commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
Author: Harbs <ha...@in-tools.com>
AuthorDate: Tue Jan 1 13:16:38 2019 +0200

    Changed clean script to only delete the swc files in libs
    
    Every ant build broke the validity of the SDK because it removed the player folder from libs
---
 frameworks/build.xml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/frameworks/build.xml b/frameworks/build.xml
index db45fcc..43c6aa3 100644
--- a/frameworks/build.xml
+++ b/frameworks/build.xml
@@ -211,7 +211,10 @@
             </fileset>
         </delete> 
         <!-- Delete empty folders -->
-        <delete dir="${basedir}/libs"/>
+        <delete dir="${basedir}/libs" failonerror="false">
+            <include name="*.swc"/>
+        </delete>
+        <!-- <delete dir="${basedir}/libs"/> -->
         <delete dir="${basedir}/locale">
             <exclude name="**/metadata.properties"/>
         </delete>


Re: [royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

Posted by Alex Harui <ah...@adobe.com.INVALID>.
I would hope that VS Code and Moonshine and any newer IDE could be modified to handle an external playerglobal/airglobal.  The compiler can handle it if you can specify +PLAYERGLOBAL_HOME=<path to playerglobal

Note the "+" in front of the option instead of "-".  And you can also specify +AIR_HOME, +playerglobal.version, IIRC.  Our Ant scripts do that.

HTH,
-Alex

I still use FB, but only as a code editor.  I don't deal with the projects.  I build with Ant or Maven since I have to make sure those work since the CI servers use them.

On 1/1/19, 11:09 PM, "Harbs" <ha...@gmail.com> wrote:

    It’s so I can use VS Code.
    
    How do you work while doing framework work?
    
    I build projects individually. Adding an extra step each time I do that makes the process more burdensome. I have an ant script in my project which copies the player files, but I have to remember to run it every time. The locations are also different on each machine.
    
    Maintaining copying scripts on four different computers is a drag.
    
    > On Jan 2, 2019, at 8:06 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
    > 
    > Is this so you can use Flash Builder?
    > 
    > IMO, we shouldn't increase the chance of error in our releases to support the repo as an FB SDK.  Add some script that copies the SWCs into a real Royale SDK.  Seems risky to have all of those category X files in the working copy.
    > 
    > -Alex
    > 
    > On 1/1/19, 10:00 PM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
    > 
    >    I’m using the royale-asjs folder as my SDK. That requires having playerglobal within the player folder inside libs.
    > 
    >    By deleting the libs folder every time, that requires an extra step of re-copying the player folder into libs every time I build royale-asjs.
    > 
    >    If you have a better idea, I’m all ears.
    > 
    >    Harbs
    > 
    >> On Jan 2, 2019, at 6:13 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
    >> 
    >> I am curious about why this change is needed.  I would think we would want to clean everything out of the folder so we don't accidentally pick up extra files packaging a release.
    >> 
    >> -Alex
    >> 
    >> On 1/1/19, 3:16 AM, "harbs@apache.org" <ha...@apache.org> wrote:
    >> 
    >>   This is an automated email from the ASF dual-hosted git repository.
    >> 
    >>   harbs pushed a commit to branch develop
    >>   in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cefc9cd7cf9874c01933608d67081469f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820097902832147&amp;sdata=afmeRk4dhKS4UbXWDg8jyenpHnYeCmiJMqVVZiqOZCE%3D&amp;reserved=0 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cefc9cd7cf9874c01933608d67081469f%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820097902832147&amp;sdata=afmeRk4dhKS4UbXWDg8jyenpHnYeCmiJMqVVZiqOZCE%3D&amp;reserved=0>
    >> 
    >> 
    >>   The following commit(s) were added to refs/heads/develop by this push:
    >>        new ef95bb4  Changed clean script to only delete the swc files in libs
    >>   ef95bb4 is described below
    >> 
    >>   commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
    >>   Author: Harbs <ha...@in-tools.com>
    >>   AuthorDate: Tue Jan 1 13:16:38 2019 +0200
    >> 
    >>       Changed clean script to only delete the swc files in libs
    >> 
    >>       Every ant build broke the validity of the SDK because it removed the player folder from libs
    >>   ---
    >>    frameworks/build.xml | 5 ++++-
    >>    1 file changed, 4 insertions(+), 1 deletion(-)
    >> 
    >>   diff --git a/frameworks/build.xml b/frameworks/build.xml
    >>   index db45fcc..43c6aa3 100644
    >>   --- a/frameworks/build.xml
    >>   +++ b/frameworks/build.xml
    >>   @@ -211,7 +211,10 @@
    >>                </fileset>
    >>            </delete> 
    >>            <!-- Delete empty folders -->
    >>   -        <delete dir="${basedir}/libs"/>
    >>   +        <delete dir="${basedir}/libs" failonerror="false">
    >>   +            <include name="*.swc"/>
    >>   +        </delete>
    >>   +        <!-- <delete dir="${basedir}/libs"/> -->
    >>            <delete dir="${basedir}/locale">
    >>                <exclude name="**/metadata.properties"/>
    >>            </delete>
    
    


Re: [royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

Posted by Harbs <ha...@gmail.com>.
It’s so I can use VS Code.

How do you work while doing framework work?

I build projects individually. Adding an extra step each time I do that makes the process more burdensome. I have an ant script in my project which copies the player files, but I have to remember to run it every time. The locations are also different on each machine.

Maintaining copying scripts on four different computers is a drag.

> On Jan 2, 2019, at 8:06 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
> 
> Is this so you can use Flash Builder?
> 
> IMO, we shouldn't increase the chance of error in our releases to support the repo as an FB SDK.  Add some script that copies the SWCs into a real Royale SDK.  Seems risky to have all of those category X files in the working copy.
> 
> -Alex
> 
> On 1/1/19, 10:00 PM, "Harbs" <harbs.lists@gmail.com <ma...@gmail.com>> wrote:
> 
>    I’m using the royale-asjs folder as my SDK. That requires having playerglobal within the player folder inside libs.
> 
>    By deleting the libs folder every time, that requires an extra step of re-copying the player folder into libs every time I build royale-asjs.
> 
>    If you have a better idea, I’m all ears.
> 
>    Harbs
> 
>> On Jan 2, 2019, at 6:13 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
>> 
>> I am curious about why this change is needed.  I would think we would want to clean everything out of the folder so we don't accidentally pick up extra files packaging a release.
>> 
>> -Alex
>> 
>> On 1/1/19, 3:16 AM, "harbs@apache.org" <ha...@apache.org> wrote:
>> 
>>   This is an automated email from the ASF dual-hosted git repository.
>> 
>>   harbs pushed a commit to branch develop
>>   in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Ccd2a00a1f1e94ea0dc8308d670778dc6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820056138390530&amp;sdata=mTyygJIaK%2Fg1aNVzHKaFaCDvs%2FCALz64hJaCorAAa%2Bs%3D&amp;reserved=0 <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Ccd2a00a1f1e94ea0dc8308d670778dc6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820056138390530&amp;sdata=mTyygJIaK%2Fg1aNVzHKaFaCDvs%2FCALz64hJaCorAAa%2Bs%3D&amp;reserved=0>
>> 
>> 
>>   The following commit(s) were added to refs/heads/develop by this push:
>>        new ef95bb4  Changed clean script to only delete the swc files in libs
>>   ef95bb4 is described below
>> 
>>   commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
>>   Author: Harbs <ha...@in-tools.com>
>>   AuthorDate: Tue Jan 1 13:16:38 2019 +0200
>> 
>>       Changed clean script to only delete the swc files in libs
>> 
>>       Every ant build broke the validity of the SDK because it removed the player folder from libs
>>   ---
>>    frameworks/build.xml | 5 ++++-
>>    1 file changed, 4 insertions(+), 1 deletion(-)
>> 
>>   diff --git a/frameworks/build.xml b/frameworks/build.xml
>>   index db45fcc..43c6aa3 100644
>>   --- a/frameworks/build.xml
>>   +++ b/frameworks/build.xml
>>   @@ -211,7 +211,10 @@
>>                </fileset>
>>            </delete> 
>>            <!-- Delete empty folders -->
>>   -        <delete dir="${basedir}/libs"/>
>>   +        <delete dir="${basedir}/libs" failonerror="false">
>>   +            <include name="*.swc"/>
>>   +        </delete>
>>   +        <!-- <delete dir="${basedir}/libs"/> -->
>>            <delete dir="${basedir}/locale">
>>                <exclude name="**/metadata.properties"/>
>>            </delete>


Re: [royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

Posted by Alex Harui <ah...@adobe.com.INVALID>.
Is this so you can use Flash Builder?

IMO, we shouldn't increase the chance of error in our releases to support the repo as an FB SDK.  Add some script that copies the SWCs into a real Royale SDK.  Seems risky to have all of those category X files in the working copy.

-Alex

On 1/1/19, 10:00 PM, "Harbs" <ha...@gmail.com> wrote:

    I’m using the royale-asjs folder as my SDK. That requires having playerglobal within the player folder inside libs.
    
    By deleting the libs folder every time, that requires an extra step of re-copying the player folder into libs every time I build royale-asjs.
    
    If you have a better idea, I’m all ears.
    
    Harbs
    
    > On Jan 2, 2019, at 6:13 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
    > 
    > I am curious about why this change is needed.  I would think we would want to clean everything out of the folder so we don't accidentally pick up extra files packaging a release.
    > 
    > -Alex
    > 
    > On 1/1/19, 3:16 AM, "harbs@apache.org" <ha...@apache.org> wrote:
    > 
    >    This is an automated email from the ASF dual-hosted git repository.
    > 
    >    harbs pushed a commit to branch develop
    >    in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Ccd2a00a1f1e94ea0dc8308d670778dc6%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636820056138390530&amp;sdata=mTyygJIaK%2Fg1aNVzHKaFaCDvs%2FCALz64hJaCorAAa%2Bs%3D&amp;reserved=0
    > 
    > 
    >    The following commit(s) were added to refs/heads/develop by this push:
    >         new ef95bb4  Changed clean script to only delete the swc files in libs
    >    ef95bb4 is described below
    > 
    >    commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
    >    Author: Harbs <ha...@in-tools.com>
    >    AuthorDate: Tue Jan 1 13:16:38 2019 +0200
    > 
    >        Changed clean script to only delete the swc files in libs
    > 
    >        Every ant build broke the validity of the SDK because it removed the player folder from libs
    >    ---
    >     frameworks/build.xml | 5 ++++-
    >     1 file changed, 4 insertions(+), 1 deletion(-)
    > 
    >    diff --git a/frameworks/build.xml b/frameworks/build.xml
    >    index db45fcc..43c6aa3 100644
    >    --- a/frameworks/build.xml
    >    +++ b/frameworks/build.xml
    >    @@ -211,7 +211,10 @@
    >                 </fileset>
    >             </delete> 
    >             <!-- Delete empty folders -->
    >    -        <delete dir="${basedir}/libs"/>
    >    +        <delete dir="${basedir}/libs" failonerror="false">
    >    +            <include name="*.swc"/>
    >    +        </delete>
    >    +        <!-- <delete dir="${basedir}/libs"/> -->
    >             <delete dir="${basedir}/locale">
    >                 <exclude name="**/metadata.properties"/>
    >             </delete>
    > 
    > 
    > 
    
    


Re: [royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

Posted by Harbs <ha...@gmail.com>.
I’m using the royale-asjs folder as my SDK. That requires having playerglobal within the player folder inside libs.

By deleting the libs folder every time, that requires an extra step of re-copying the player folder into libs every time I build royale-asjs.

If you have a better idea, I’m all ears.

Harbs

> On Jan 2, 2019, at 6:13 AM, Alex Harui <ah...@adobe.com.INVALID> wrote:
> 
> I am curious about why this change is needed.  I would think we would want to clean everything out of the folder so we don't accidentally pick up extra files packaging a release.
> 
> -Alex
> 
> On 1/1/19, 3:16 AM, "harbs@apache.org" <ha...@apache.org> wrote:
> 
>    This is an automated email from the ASF dual-hosted git repository.
> 
>    harbs pushed a commit to branch develop
>    in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cf61d188d5f954c3d1c6008d66fdaa320%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636819382183366808&amp;sdata=7vsISfScV30eiqVpGRT%2Ba%2Fg78%2FLrdxCaBqxjVZGARio%3D&amp;reserved=0
> 
> 
>    The following commit(s) were added to refs/heads/develop by this push:
>         new ef95bb4  Changed clean script to only delete the swc files in libs
>    ef95bb4 is described below
> 
>    commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
>    Author: Harbs <ha...@in-tools.com>
>    AuthorDate: Tue Jan 1 13:16:38 2019 +0200
> 
>        Changed clean script to only delete the swc files in libs
> 
>        Every ant build broke the validity of the SDK because it removed the player folder from libs
>    ---
>     frameworks/build.xml | 5 ++++-
>     1 file changed, 4 insertions(+), 1 deletion(-)
> 
>    diff --git a/frameworks/build.xml b/frameworks/build.xml
>    index db45fcc..43c6aa3 100644
>    --- a/frameworks/build.xml
>    +++ b/frameworks/build.xml
>    @@ -211,7 +211,10 @@
>                 </fileset>
>             </delete> 
>             <!-- Delete empty folders -->
>    -        <delete dir="${basedir}/libs"/>
>    +        <delete dir="${basedir}/libs" failonerror="false">
>    +            <include name="*.swc"/>
>    +        </delete>
>    +        <!-- <delete dir="${basedir}/libs"/> -->
>             <delete dir="${basedir}/locale">
>                 <exclude name="**/metadata.properties"/>
>             </delete>
> 
> 
> 


Re: [royale-asjs] branch develop updated: Changed clean script to only delete the swc files in libs

Posted by Alex Harui <ah...@adobe.com.INVALID>.
I am curious about why this change is needed.  I would think we would want to clean everything out of the folder so we don't accidentally pick up extra files packaging a release.

-Alex

On 1/1/19, 3:16 AM, "harbs@apache.org" <ha...@apache.org> wrote:

    This is an automated email from the ASF dual-hosted git repository.
    
    harbs pushed a commit to branch develop
    in repository https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitbox.apache.org%2Frepos%2Fasf%2Froyale-asjs.git&amp;data=02%7C01%7Caharui%40adobe.com%7Cf61d188d5f954c3d1c6008d66fdaa320%7Cfa7b1b5a7b34438794aed2c178decee1%7C0%7C0%7C636819382183366808&amp;sdata=7vsISfScV30eiqVpGRT%2Ba%2Fg78%2FLrdxCaBqxjVZGARio%3D&amp;reserved=0
    
    
    The following commit(s) were added to refs/heads/develop by this push:
         new ef95bb4  Changed clean script to only delete the swc files in libs
    ef95bb4 is described below
    
    commit ef95bb4c90f55c91920679c7c4a37842dd1904f9
    Author: Harbs <ha...@in-tools.com>
    AuthorDate: Tue Jan 1 13:16:38 2019 +0200
    
        Changed clean script to only delete the swc files in libs
        
        Every ant build broke the validity of the SDK because it removed the player folder from libs
    ---
     frameworks/build.xml | 5 ++++-
     1 file changed, 4 insertions(+), 1 deletion(-)
    
    diff --git a/frameworks/build.xml b/frameworks/build.xml
    index db45fcc..43c6aa3 100644
    --- a/frameworks/build.xml
    +++ b/frameworks/build.xml
    @@ -211,7 +211,10 @@
                 </fileset>
             </delete> 
             <!-- Delete empty folders -->
    -        <delete dir="${basedir}/libs"/>
    +        <delete dir="${basedir}/libs" failonerror="false">
    +            <include name="*.swc"/>
    +        </delete>
    +        <!-- <delete dir="${basedir}/libs"/> -->
             <delete dir="${basedir}/locale">
                 <exclude name="**/metadata.properties"/>
             </delete>