[PR] NIFI-14414 Add Request Details to Flow Action Reporting [nifi]

["exceptionfactory (via GitHub)" <gi...@apache.org>]

exceptionfactory opened a new pull request, #9881:
URL: https://github.com/apache/nifi/pull/9881

   # Summary
   
   [NIFI-14414](https://issues.apache.org/jira/browse/NIFI-14414) Adds HTTP Request Details for `FlowAction` records reported to the new `FlowActionReporter` defined in `nifi-framework-api`.
   
   The HTTP Request Details include the socket Remote Address, the `X-Forwarded-For` header value when present, and the `User-Agent` header.
   
   The implementation adds a new `RequestAction` interface in `nifi-framework-api`, which has a `RequestDetails` get method. The standard framework module has an existing `FlowChangeAction` that implements `Action` from `nifi-api` and also implements `RequestAction`. This approach scopes the addition of HTTP Request Details to the `nifi-framework-api`, aligning with the general design of the `FlowActionReporter` framework extension.
   
   The majority of the changes consist of updating the `Auditor` implementation classes to use a new shared `createFlowChangeAction()` method, which encapsulates the logic required to get the current `Authentication` object from the Spring Security Context and read the HTTP Request Details from the `WebAuthenticationDetails` populated during Spring Security Filter Chain processing.
   
   Additional changes include a new system test and `SystemTestFlowActionReporter`. The `FlowActionReporter` writes serialized Flow Action attributes to files, and the integration checks for the existence of the log file, confirming the it contains a reference to a Processor created in the flow configuration.
   
   # Tracking
   
   Please complete the following tracking steps prior to pull request creation.
   
   ### Issue Tracking
   
   - [X] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
   
   ### Pull Request Tracking
   
   - [X] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
   - [X] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
   
   ### Pull Request Formatting
   
   - [X] Pull Request based on current revision of the `main` branch
   - [X] Pull Request refers to a feature branch with one commit containing changes
   
   # Verification
   
   Please indicate the verification steps performed prior to pull request creation.
   
   ### Build
   
   - [X] Build completed using `mvn clean install -P contrib-check`
     - [X] JDK 21
   
   ### Licensing
   
   - [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
   - [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
   
   ### Documentation
   
   - [ ] Documentation formatting appears as expected in rendered files
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] NIFI-14414 Add Request Details to Flow Action Reporting [nifi]

["bbende (via GitHub)" <gi...@apache.org>]

bbende merged PR #9881:
URL: https://github.com/apache/nifi/pull/9881


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org