You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/01/23 07:07:29 UTC
[GitHub] [kafka] sayantanu-dey opened a new pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
sayantanu-dey opened a new pull request #11704:
URL: https://github.com/apache/kafka/pull/11704
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.*
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] sayantanu-dey edited a comment on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
Posted by GitBox <gi...@apache.org>.
sayantanu-dey edited a comment on pull request #11704:
URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020145591
> @sayantanu-dey hi, I wonder where the name came from, it's really a good name in context.
@Kvicii hi, thanks, I just saw that the function was returning the Map of subtopology to TopicInfo, so I thought of having that as the name :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] sayantanu-dey commented on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
Posted by GitBox <gi...@apache.org>.
sayantanu-dey commented on pull request #11704:
URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020145591
> @sayantanu-dey hi, I wonder where the name came from, it's really a good name in context.
@Kvicii hi, thanks, I just saw that the function was returning the Map of subtopology and TopicInfo, so I thought of having that as the name :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] Kvicii commented on pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
Posted by GitBox <gi...@apache.org>.
Kvicii commented on pull request #11704:
URL: https://github.com/apache/kafka/pull/11704#issuecomment-1020117719
@sayantanu-dey hi, I wonder where the name came from, it's really a good name in context.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11704:
URL: https://github.com/apache/kafka/pull/11704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] ableegoldman merged pull request #11704: KAFKA-13590: rename InternalTopologyBuilder#topicGroups
Posted by GitBox <gi...@apache.org>.
ableegoldman merged pull request #11704:
URL: https://github.com/apache/kafka/pull/11704
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org