You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2019/12/06 14:34:06 UTC
[GitHub] [httpcomponents-client] ok2c commented on a change in pull request
#179: WIP: HTTPCLIENT-2034: Introduce HttpRequestRetryStrategy
ok2c commented on a change in pull request #179: WIP: HTTPCLIENT-2034: Introduce HttpRequestRetryStrategy
URL: https://github.com/apache/httpcomponents-client/pull/179#discussion_r354860710
##########
File path: httpclient5/src/main/java/org/apache/hc/client5/http/impl/async/AsyncHttpRequestRetryExec.java
##########
@@ -0,0 +1,177 @@
+/*
+ * ====================================================================
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ * ====================================================================
+ *
+ * This software consists of voluntary contributions made by many
+ * individuals on behalf of the Apache Software Foundation. For more
+ * information on the Apache Software Foundation, please see
+ * <http://www.apache.org/>.
+ *
+ */
+package org.apache.hc.client5.http.impl.async;
+
+import java.io.IOException;
+import java.io.InterruptedIOException;
+
+import org.apache.hc.client5.http.HttpRequestRetryStrategy;
+import org.apache.hc.client5.http.HttpRoute;
+import org.apache.hc.client5.http.async.AsyncExecCallback;
+import org.apache.hc.client5.http.async.AsyncExecChain;
+import org.apache.hc.client5.http.async.AsyncExecChainHandler;
+import org.apache.hc.client5.http.impl.RequestCopier;
+import org.apache.hc.client5.http.protocol.HttpClientContext;
+import org.apache.hc.core5.annotation.Contract;
+import org.apache.hc.core5.annotation.Internal;
+import org.apache.hc.core5.annotation.ThreadingBehavior;
+import org.apache.hc.core5.http.EntityDetails;
+import org.apache.hc.core5.http.HttpException;
+import org.apache.hc.core5.http.HttpRequest;
+import org.apache.hc.core5.http.HttpResponse;
+import org.apache.hc.core5.http.nio.AsyncDataConsumer;
+import org.apache.hc.core5.http.nio.AsyncEntityProducer;
+import org.apache.hc.core5.util.Args;
+import org.apache.hc.core5.util.TimeValue;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * Request executor in the asynchronou srequest execution chain that is
+ * responsible for making a decision whether a request than failed due to
+ * an I/O error or received specific response from the target server should
+ * be re-executed.
+ * <p>
+ * Further responsibilities such as communication with the opposite
+ * endpoint is delegated to the next executor in the request execution
+ * chain.
+ * </p>
+ *
+ * @since 5.0
+ */
+@Contract(threading = ThreadingBehavior.STATELESS)
+@Internal
+public final class AsyncHttpRequestRetryExec implements AsyncExecChainHandler {
+
+ private final Logger log = LoggerFactory.getLogger(getClass());
+
+ private final HttpRequestRetryStrategy retryStrategy;
+
+ public AsyncHttpRequestRetryExec(final HttpRequestRetryStrategy retryStrategy) {
+ Args.notNull(retryStrategy, "retryStrategy");
+ this.retryStrategy = retryStrategy;
+ }
+
+ private void internalExecute(
+ final int execCount,
+ final HttpRequest request,
+ final AsyncEntityProducer entityProducer,
+ final AsyncExecChain.Scope scope,
+ final AsyncExecChain chain,
+ final AsyncExecCallback asyncExecCallback) throws HttpException, IOException {
+
+ final String exchangeId = scope.exchangeId;
+
+ chain.proceed(RequestCopier.INSTANCE.copy(request), entityProducer, scope, new AsyncExecCallback() {
+
+ @Override
+ public AsyncDataConsumer handleResponse(
+ final HttpResponse response,
+ final EntityDetails entityDetails) throws HttpException, IOException {
+ final HttpClientContext clientContext = scope.clientContext;
+ try {
+ if (entityProducer != null && !entityProducer.isRepeatable()) {
+ log.debug("{}: cannot retry non-repeatable request", exchangeId);
+ return asyncExecCallback.handleResponse(response, entityDetails);
+ }
+ if (retryStrategy.retryRequest(response, execCount, clientContext)) {
+ // TODO What to do here?
+ //response.close();
+ final TimeValue nextInterval =
+ retryStrategy.getRetryInterval(response, execCount, clientContext);
+ if (TimeValue.isPositive(nextInterval)) {
+ try {
+ log.debug("{}: wait for {}", exchangeId, nextInterval);
+ nextInterval.sleep();
Review comment:
@michael-o We obviously cannot just block the i/o dispatch thread as that would also block all other channels managed by the same selector. There is actually no easy way of implementing an execution delay with an event driven execution handler. We likely need a worker thread and a `ScheduledExecutorService`. For the time being I am going to remove `#getRetryInterval` call from the async processing chain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org