You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/03/15 19:43:39 UTC
[GitHub] [netbeans] mbien opened a new pull request #3785: github actions ci pipeline.
mbien opened a new pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785
simple CI pipeline
- main job builds everything and uploads the build artifact tar (retention set to 1 day)
- all other jobs extract the tar and run their tests
Job dependencies only work within a workflow, so we have to merge them all (again). The reason they were split was to be able to restart them individually on failure.
Github finally released today a feature which allows individual jobs to be restarted. Assuming it works as expected, we won't need separate workflows anymore.
Lets see how this works and if you can actually restart a job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832400134
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Commit Validation tests
+ run: ant -Dcluster.config=release commit-validation
+
+ linux-build-system-test:
+ needs: base-build
+ name: Build-System Test on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Test Netbeans Build System
+ run: ant -Dcluster.config=release localtest
+
+ linux-javadoc:
+ needs: base-build
+ name: Build NBMs, Source zips and Javadoc on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Get maven coordinates
+ run: ant getallmavencoordinates
+
+ - name: Build nbms
+ run: ant build-nbms
+
+ - name: Build source zips
+ run: ant build-source-zips
+
+ - name: Build javadoc
+ run: ant build-javadoc
+
+ macos:
+ needs: base-build
+ name: Tests on MacOS/JDK ${{ matrix.java }}
+ runs-on: macos-11
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/Library/Caches/Homebrew
+ key: ${{ runner.os }}-homebrew
+ restore-keys: ${{ runner.os }}-homebrew
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - run: brew install ant
+
+ - name: Test platform/masterfs.macosx
+ run: ant -f platform/masterfs.macosx test
Review comment:
potentially. What is the ant target for creating the test distribution? Some secondary jobs probably won't work with that though. E.g the nbm one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r828320950
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@neilcsmith-net do you think it is a problem from the apache resources perspective that a build would create a 1.5 GB upload ([accessible from bottom of this page](https://github.com/apache/netbeans/actions/runs/1989525198))? 1 day retention is already the minimal setting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1081561234
@oyarzun done
artifact retention:
I added a cleanup job which removes the artifact at the very end of the workflow run.
last run: https://github.com/apache/netbeans/actions/runs/2056554946
(notice there is no artifact linked at the bottom of the page)
Retention time doesn't matter anymore, it is now removed right away. The action is deployed via a git sub module as suggested by @neilcsmith-net https://github.com/apache/netbeans/pull/3785#issuecomment-1069037190
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r837927048
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@neilcsmith-net ok to merge or should we wait for infra reply? I am no longer concerned about the storage issue due to the cleanup job which was much easier to implement than anticipated thanks to the third party gh action (deployed via the submodule trick).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1082384134
squashed all commits.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834494183
##########
File path: .github/workflows/ensure-jdk8.yml
##########
@@ -1,60 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: Ensure JDK-8
-
-on:
- push:
- pull_request:
-
-jobs:
- jdk11-jdk8:
- name: "Compile with JDK-11 and test something on JDK-8"
- runs-on: ubuntu-18.04
- env:
- OPTS: -Dcluster.config=basic -Dtest-unit-sys-prop.ignore.random.failures=true
- steps:
- - uses: actions/checkout@v2
-
- - name: Caching dependencies
- uses: actions/cache@v2
- with:
- path: ~/.hgexternalcache
- key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
- restore-keys: ${{ runner.os }}-
-
- - name: Set up JDK 8
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 8
-
- - name: Record JDK8
- run: echo "$JAVA_HOME" | tee `pwd`/jdk8
-
- - name: Set up JDK 11
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 11
-
-
- - name: Build
- run: ant $OPTS build
-
- - name: Test java.source.base on JDK-8
Review comment:
Testing on JDK 8 is covered by travis: https://github.com/apache/netbeans/blob/0665eb12aaa64cbe3b7bae657f46594a579a41cc/.travis.yml#L383
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1071970967
@junichi11 @oyarzun the PHP code folding test appears to have some issues on JDK 11, is this known?
build on 11, test on 11:
https://github.com/apache/netbeans/actions/runs/2000384843
both, win and linux nodes fail
build on 8, test on 8 and 11 (only enabled for debugging purposes):
https://github.com/apache/netbeans/actions/runs/2001457064
linux/jdk11 node fails, other three nodes are green
@oyarzun I have a question, why did you change $OPTS to $env:OPTS? Is this valid syntax? (I changed it back when i merged the workflows into a matrix job since i had to pick one variant - but if that was intended i can change it back)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
I hope we don't have to declare everything twice as suggested here:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#detecting-the-operating-system
`${{ env.OPTS }}` might potentially work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
I hope we don't have to declare everything twice as suggested here:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#detecting-the-operating-system
`${{ env.OPTS }}` might potentially work.
i will also check if we can swap out the shell on windows using
`shell: bash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832188275
##########
File path: .github/workflows/ensure-jdk8.yml
##########
@@ -1,60 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: Ensure JDK-8
-
-on:
- push:
- pull_request:
-
-jobs:
- jdk11-jdk8:
- name: "Compile with JDK-11 and test something on JDK-8"
- runs-on: ubuntu-18.04
- env:
- OPTS: -Dcluster.config=basic -Dtest-unit-sys-prop.ignore.random.failures=true
- steps:
- - uses: actions/checkout@v2
-
- - name: Caching dependencies
- uses: actions/cache@v2
- with:
- path: ~/.hgexternalcache
- key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
- restore-keys: ${{ runner.os }}-
-
- - name: Set up JDK 8
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 8
-
- - name: Record JDK8
- run: echo "$JAVA_HOME" | tee `pwd`/jdk8
-
- - name: Set up JDK 11
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 11
-
-
- - name: Build
- run: ant $OPTS build
-
- - name: Test java.source.base on JDK-8
Review comment:
I am not sure what replaces testing on JDK8? I am against deleting any jobs that perform testing on JDK8 unless they are replaced by appropriate alternative.
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Commit Validation tests
+ run: ant -Dcluster.config=release commit-validation
+
+ linux-build-system-test:
+ needs: base-build
+ name: Build-System Test on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Test Netbeans Build System
+ run: ant -Dcluster.config=release localtest
+
+ linux-javadoc:
+ needs: base-build
+ name: Build NBMs, Source zips and Javadoc on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Get maven coordinates
+ run: ant getallmavencoordinates
+
+ - name: Build nbms
+ run: ant build-nbms
+
+ - name: Build source zips
+ run: ant build-source-zips
+
+ - name: Build javadoc
+ run: ant build-javadoc
+
+ macos:
+ needs: base-build
+ name: Tests on MacOS/JDK ${{ matrix.java }}
+ runs-on: macos-11
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/Library/Caches/Homebrew
+ key: ${{ runner.os }}-homebrew
+ restore-keys: ${{ runner.os }}-homebrew
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - run: brew install ant
+
+ - name: Test platform/masterfs.macosx
+ run: ant -f platform/masterfs.macosx test
Review comment:
Could we use _test distribution_ instead of the tar?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834668534
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
Thats interesting! Going to try to replace the JDK 15 job with 17 + add 19ea. I am wondering why i had issues last time i tried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r835800550
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@matthiasblaesing @neilcsmith-net if I take a look at https://github.com/pricing
I see "Free for public repositories" under the `Package storage` item. Does this mean we shouldn't have to worry here?
I could try to add a cleanup job which removes the upload again.
for example a variant of: https://github.com/actions/upload-artifact/issues/5#issuecomment-876499762 but only for the current workflow or https://github.com/christian-korneck/delete-run-artifacts-action, but this is going to need more setup work (access tokens most likely).
Or should we give it a try first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r837155270
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
```
Run ./.github/actions/delete-artifact/
Successfully deleted artifact "build".
```
it works :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
I hope we don't have to declare everything twice as suggested here:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#detecting-the-operating-system
${{ env.OPTS }} might potentially work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832409935
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Commit Validation tests
+ run: ant -Dcluster.config=release commit-validation
+
+ linux-build-system-test:
+ needs: base-build
+ name: Build-System Test on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Test Netbeans Build System
+ run: ant -Dcluster.config=release localtest
+
+ linux-javadoc:
+ needs: base-build
+ name: Build NBMs, Source zips and Javadoc on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Get maven coordinates
+ run: ant getallmavencoordinates
+
+ - name: Build nbms
+ run: ant build-nbms
+
+ - name: Build source zips
+ run: ant build-source-zips
+
+ - name: Build javadoc
+ run: ant build-javadoc
+
+ macos:
+ needs: base-build
+ name: Tests on MacOS/JDK ${{ matrix.java }}
+ runs-on: macos-11
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/Library/Caches/Homebrew
+ key: ${{ runner.os }}-homebrew
+ restore-keys: ${{ runner.os }}-homebrew
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - run: brew install ant
+
+ - name: Test platform/masterfs.macosx
+ run: ant -f platform/masterfs.macosx test
Review comment:
@JaroslavTulach but let me ask first: is there a reason you prefer a test distribution over the full workspace approach? It is basically like testing a fresh clone, just from a snapshot which has been already built.
My main argument for a test-dist is the reduced artifact size (it still going to be big!). But I am not sure if that is a problem with 1 day retention time. Its likely that we will have to ask someone from apache infra anyway - even if we reduce the artifact size by using a test dist build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834586106
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
@matthiasblaesing good to know! Could we leave it here and remove the jobs on travis instead? I prefer gh actions over travis personally - not sure what others think (and it is using a pipeline which means less building which makes about 10min per job).
We might have to leave the job for 15 on travis since I don't think anyone maintains EOL JDK setups for gh actions. But if someone does - even better.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834868531
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,347 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '8', '11', '17', '19-ea' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: JMS config
+ if: ${{ matrix.java != '8' }}
+ run: echo "JAVA_TOOL_OPTIONS=--add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED" >> $GITHUB_ENV
Review comment:
19-ea fails currently. It appears JDK 19 requires now `-Djava.security.manager=allow` to be set, since the warning became now a runtime exception:
```
[junit] java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release
[junit] at java.base/java.lang.System.setSecurityManager(System.java:416)
[junit] at org.netbeans.TopSecurityManager.install(TopSecurityManager.java:525)
[junit] at org.netbeans.core.NbLifecycleManager.advancePolicy(NbLifecycleManager.java:69)
[junit] at org.netbeans.core.GuiRunLevel.run(GuiRunLevel.java:84)
[junit] at org.netbeans.core.startup.Main.start(Main.java:312)
[junit] at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:98)
[junit] at java.base/java.lang.Thread.run(Thread.java:828)
```
i couldn't find the OpenJDK PR for that but i haven't searched very long
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1071970967
@junichi11 @oyarzun the PHP code folding test appears to have some issues on JDK 11, is this known?
build on 11, test on 11:
https://github.com/apache/netbeans/actions/runs/2000384843
both, win and linux nodes fail
build on 8, test on 8 and 11 (only enabled for debugging purposes):
https://github.com/apache/netbeans/actions/runs/2001457064
linux/jdk11 node fails, other three nodes are green
edit: setting -Dnb.php.editor.doNotFoldPhptag=false didn't help (made it worse in fact)
https://github.com/apache/netbeans/actions/runs/2005204866
@oyarzun I have a question, why did you change $OPTS to $env:OPTS? Is this valid syntax? (I changed it back when i merged the workflows into a matrix job since i had to pick one variant - but if that was intended i can change it back)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832389463
##########
File path: .github/workflows/ensure-jdk8.yml
##########
@@ -1,60 +0,0 @@
-# Licensed to the Apache Software Foundation (ASF) under one
-# or more contributor license agreements. See the NOTICE file
-# distributed with this work for additional information
-# regarding copyright ownership. The ASF licenses this file
-# to you under the Apache License, Version 2.0 (the
-# "License"); you may not use this file except in compliance
-# with the License. You may obtain a copy of the License at
-#
-# http://www.apache.org/licenses/LICENSE-2.0
-#
-# Unless required by applicable law or agreed to in writing,
-# software distributed under the License is distributed on an
-# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
-# KIND, either express or implied. See the License for the
-# specific language governing permissions and limitations
-# under the License.
-
-name: Ensure JDK-8
-
-on:
- push:
- pull_request:
-
-jobs:
- jdk11-jdk8:
- name: "Compile with JDK-11 and test something on JDK-8"
- runs-on: ubuntu-18.04
- env:
- OPTS: -Dcluster.config=basic -Dtest-unit-sys-prop.ignore.random.failures=true
- steps:
- - uses: actions/checkout@v2
-
- - name: Caching dependencies
- uses: actions/cache@v2
- with:
- path: ~/.hgexternalcache
- key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
- restore-keys: ${{ runner.os }}-
-
- - name: Set up JDK 8
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 8
-
- - name: Record JDK8
- run: echo "$JAVA_HOME" | tee `pwd`/jdk8
-
- - name: Set up JDK 11
- uses: actions/setup-java@v2
- with:
- distribution: 'zulu'
- java-version: 11
-
-
- - name: Build
- run: ant $OPTS build
-
- - name: Test java.source.base on JDK-8
Review comment:
we (you?) added that on travis as far as I know. It builds on 11 and tests on 8. I am ok with adding it to the actions (again), but we should check that nothing is tested twice to conserve resources.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834668534
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
Thats interesting! Going to try to replace the JDK 15 job with 17 + add 18. I am wondering why i had issues last time i tried.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832409935
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Commit Validation tests
+ run: ant -Dcluster.config=release commit-validation
+
+ linux-build-system-test:
+ needs: base-build
+ name: Build-System Test on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Test Netbeans Build System
+ run: ant -Dcluster.config=release localtest
+
+ linux-javadoc:
+ needs: base-build
+ name: Build NBMs, Source zips and Javadoc on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ strategy:
+ matrix:
+ java: [ '11' ]
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: Get maven coordinates
+ run: ant getallmavencoordinates
+
+ - name: Build nbms
+ run: ant build-nbms
+
+ - name: Build source zips
+ run: ant build-source-zips
+
+ - name: Build javadoc
+ run: ant build-javadoc
+
+ macos:
+ needs: base-build
+ name: Tests on MacOS/JDK ${{ matrix.java }}
+ runs-on: macos-11
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - uses: actions/cache@v2
+ with:
+ path: ~/Library/Caches/Homebrew
+ key: ${{ runner.os }}-homebrew
+ restore-keys: ${{ runner.os }}-homebrew
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - run: brew install ant
+
+ - name: Test platform/masterfs.macosx
+ run: ant -f platform/masterfs.macosx test
Review comment:
but let me ask first: is there a reason you prefer a test distribution over the full workspace approach? It is basically like testing a fresh clone, just from a snapshot which is already built.
My main argument against it is the artifact size. But I am not sure if that is a problem with 1 day retention time. Its likely that we will have to ask someone from apache infra anyway - even if we reduce the artifact size by using a test dist build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834868531
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,347 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '8', '11', '17', '19-ea' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: JMS config
+ if: ${{ matrix.java != '8' }}
+ run: echo "JAVA_TOOL_OPTIONS=--add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED" >> $GITHUB_ENV
Review comment:
19-ea fails currently. It appears JDK 19 requires now `-Djava.security.manager=allow` to be set, since the warning became now a runtime exception:
```
[junit] java.lang.UnsupportedOperationException: The Security Manager is deprecated and will be removed in a future release
[junit] at java.base/java.lang.System.setSecurityManager(System.java:416)
[junit] at org.netbeans.TopSecurityManager.install(TopSecurityManager.java:525)
[junit] at org.netbeans.core.NbLifecycleManager.advancePolicy(NbLifecycleManager.java:69)
[junit] at org.netbeans.core.GuiRunLevel.run(GuiRunLevel.java:84)
[junit] at org.netbeans.core.startup.Main.start(Main.java:312)
[junit] at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:98)
[junit] at java.base/java.lang.Thread.run(Thread.java:828)
```
but even if the flag is set (tested it locally) it would fail later:
```
[nb-javac] Compiling 1 source file to /home/mbien/NetBeansProjects/netbeans/java/java.hints/build/classes
[nb-javac] /home/mbien/NetBeansProjects/netbeans/java/java.hints/src/org/netbeans/modules/java/hints/bugs/Unused.java:82: error: cannot find symbol
[nb-javac] fix = JavaFixUtilities.safelyRemoveFromParent(ctx, Bundle.FIX_RemoveUsedElement(name), ud.unusedElementPath);
[nb-javac] ^
[nb-javac] symbol: method safelyRemoveFromParent(HintContext,String,TreePath)
[nb-javac] location: class JavaFixUtilities
[nb-javac] 1 error
```
I will swap 19-ea with 18 for now since more work is needed there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1069176068
> JFTR - various ASF projects are using git submodules if there is a need for third-party actions - eg. see [apache/superset#12709](https://github.com/apache/superset/pull/12709)
hi @neilcsmith-net, I didn't know that windows learned what a tar is. It turns out that there is no need for that action. But good to know that there is a trick available if it would be still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834609760
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
@matthiasblaesing cv doesn't work on 15+ unfortunately (like a lot of other tests). Blocked by netbinox the last time i tried. If that is unblocked (and no other issue shows up) its likely that it would also require the `--add-opens` lists (which we [now have](https://github.com/apache/netbeans/tree/master/nbbuild/jms-config), so we made some progress in that area at least).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
I hope we don't have to declare everything twice as suggested here:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#detecting-the-operating-system
`${{ env.OPTS }}` might potentially work.
i will also check if we can swap out the shell on windows using
`shell: bash`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r835800550
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@matthiasblaesing @neilcsmith-net if I take a look at https://github.com/pricing
I see "Free for public repositories" under the Package storage item. Does this mean we shouldn't have to worry here?
I could try to add a cleanup job which removes the upload again. (for example a variant of: https://github.com/actions/upload-artifact/issues/5#issuecomment-876499762 but only for the current workflow)
Or should we give it a try first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1069037190
JFTR - various ASF projects are using git submodules if there is a need for third-party actions - eg. see https://github.com/apache/superset/pull/12709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072015324
@mbien Maybe, the same as https://github.com/apache/netbeans/pull/3444 ? (See my comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072015324
@mbien Maybe, the same as https://github.com/apache/netbeans/pull/3444 ? (See my comments)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r832210617
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
Commit validation shall run on JDK8 as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834903140
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,347 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '8', '11', '17', '19-ea' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: JMS config
+ if: ${{ matrix.java != '8' }}
+ run: echo "JAVA_TOOL_OPTIONS=--add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED" >> $GITHUB_ENV
Review comment:
19-ea job is now green too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r838356649
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@mbien I reckon it's reasonable as is. Let's merge and deal with any fallout later! :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r835800550
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@matthiasblaesing @neilcsmith-net if I take a look at https://github.com/pricing
I see "Free for public repositories" under the `Package storage` item. Does this mean we shouldn't have to worry here?
I could try to add a cleanup job which removes the upload again. (for example a variant of: https://github.com/actions/upload-artifact/issues/5#issuecomment-876499762 but only for the current workflow)
Or should we give it a try first?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834596269
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
For travis vs. github action I have no strong feelings either way, so from my perspective we should just see, that they run only once.
For 15 I would consider moving to 17 and limit the test matrix to LTS versions (8, 11, 17) and the current early access version. I.e. from this list:
https://github.com/java-native-access/jna/pull/1428/files#diff-944291df2c9c06359d37cc8833d182d705c9e8c3108e7cfe132d61a06e9133ddR16
I would drop 18.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1071970967
@junichi11 @oyarzun the PHP code folding test appears to have some issues on JDK 11, is this known?
build on 11, test on 11:
https://github.com/apache/netbeans/actions/runs/2000384843
both, win and linux nodes fail
build on 8, test on 8 and 11 (only enabled for debugging purposes):
https://github.com/apache/netbeans/actions/runs/2001457064
linux/jdk11 node fails, other three nodes are green
@oyarzun I have a question, why did you change $OPTS to $env:OPTS? Is this valid syntax? (I changed it back when i merged the workflows into a matrix job since i had to pick one variant - but if that was intended i can change it back)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] oyarzun commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
oyarzun commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072658964
> @oyarzun I have a question, why did you change $OPTS to $env:OPTS? Is this valid syntax? (I changed it back when i merged the workflows into a matrix job since i had to pick one variant - but if that was intended i can change it back)
@mbien According to the GitHub docs Windows uses powershell and the environment variables should use $env:VARNAME.
https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien edited a comment on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien edited a comment on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072664300
> https://docs.github.com/en/actions/learn-github-actions/environment-variables#about-environment-variables
>
> > By default, Linux runners use the bash shell, so you must use the syntax $NAME. If the workflow specified a Windows runner, you would use the syntax for PowerShell, $env:NAME.
oh boy. I feared it would be something like that. This will complicate matrix jobs. Thanks for the info.
I hope we don't have to declare everything twice as suggested here:
https://docs.github.com/en/actions/learn-github-actions/environment-variables#detecting-the-operating-system
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072908141
@junichi11 i am going to leave the PHP tests on JDK 8, the flag didn't help unfortunately. Would be good if someone else could take a look at this so that we can bump it to 11 - but no need to hurry.
@oyarzun `shell: bash` worked: we can now use the same shell on all nodes
assuming this build is green, I will do a force push with another matrix job update for the base-build and set this PR to ready for review and will maybe drop a mail to the dev list about this and the other draft PR #3781.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] junichi11 commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
junichi11 commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1072910158
@mbien OK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r836192780
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@mbien I'd run it past infra@. Not sure of the answer. Pricing may not be relevant info - ASF is sponsored by GitHub (with enterprise org features IIRC) but what that means for reasonable resource usage in practice I don't know for sure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834659454
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
> @matthiasblaesing cv doesn't work on 15+ unfortunately (like a lot of other tests). Blocked by netbinox the last time i tried. If that is unblocked (and no other issue shows up) its likely that it would also require the `--add-opens` lists (which we [now have](https://github.com/apache/netbeans/tree/master/nbbuild/jms-config), so we made some progress in that area at least).
I had a look at the output and this is the offender:
```
[junit] März 24, 2022 8:33:03 PM org.netbeans.ProxyURLStreamHandlerFactory register
[junit] SCHWERWIEGEND: No way to find original stream handler for jar protocol
[junit] java.lang.reflect.InaccessibleObjectException: Unable to make field transient java.net.URLStreamHandler java.net.URL.handler accessible: module java.base does not "opens java.net" to unnamed module @15eb5ee5
[junit] at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:354)
[junit] at java.base/java.lang.reflect.AccessibleObject.checkCanSetAccessible(AccessibleObject.java:297)
[junit] at java.base/java.lang.reflect.Field.checkCanSetAccessible(Field.java:184)
[junit] at java.base/java.lang.reflect.Field.setAccessible(Field.java:178)
[junit] at org.netbeans.ProxyURLStreamHandlerFactory.register(ProxyURLStreamHandlerFactory.java:59)
[junit] at org.netbeans.JarClassLoader.<clinit>(JarClassLoader.java:117)
[junit] at org.netbeans.MainImpl.execute(MainImpl.java:153)
[junit] at org.netbeans.MainImpl.main(MainImpl.java:60)
[junit] at org.netbeans.Main.main(Main.java:58)
[junit] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
[junit] at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:76)
[junit] at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:51)
```
and indeed `commit-validation` succeeds if you run:
```bash
export JAVA_TOOL_OPTIONS='--add-opens=java.base/java.net=ALL-UNNAMED
```
before. I tested with a jdk-18-ea version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r834649222
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,342 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11' ]
Review comment:
added (8, 11, 15) to the commit-validaiton matrix + removed the same jobs from travis.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r835855907
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,347 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+# artifact is only produced once in the matrix
+ base-build:
+ name: Build Clusters on JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '11', '17' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ if: ${{ matrix.java == '11' }}
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ if: ${{ matrix.java == '11' }}
+ uses: actions/upload-artifact@v3
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
+ if-no-files-found: error
+
+
+# secondary jobs
+ linux-commit-validation:
+ needs: base-build
+ name: Commit Validation on Linux/JDK ${{ matrix.java }}
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ strategy:
+ matrix:
+ java: [ '8', '11', '17', '19-ea' ]
+ fail-fast: false
+ steps:
+
+ - name: Set up JDK ${{ matrix.java }}
+ uses: actions/setup-java@v2
+ with:
+ java-version: ${{ matrix.java }}
+ distribution: 'zulu'
+
+ - name: Download Build
+ uses: actions/download-artifact@v3
+ with:
+ name: build
+
+ - name: Extract
+ run: tar -xzf build.tar.gz --exclude nbbuild/build/test
+
+ - name: JMS config
+ if: ${{ matrix.java != '8' }}
+ run: echo "JAVA_TOOL_OPTIONS=--add-opens=java.base/java.net=ALL-UNNAMED --add-opens=java.desktop/javax.swing=ALL-UNNAMED" >> $GITHUB_ENV
Review comment:
found the OpenJDK PR: https://github.com/openjdk/jdk/pull/5204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on a change in pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on a change in pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#discussion_r837002226
##########
File path: .github/workflows/main.yml
##########
@@ -0,0 +1,435 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: NetBeans
+
+on:
+ push:
+ pull_request:
+
+jobs:
+
+# primary build job, most other jobs use the artifact produced here
+ base-build:
+ name: Build Clusters on JDK 11
+ runs-on: ubuntu-latest
+ env:
+ ANT_OPTS: -Dmetabuild.jsonurl=https://raw.githubusercontent.com/apache/netbeans-jenkins-lib/master/meta/netbeansrelease.json
+ steps:
+
+ - name: Set up JDK 11
+ uses: actions/setup-java@v2
+ with:
+ java-version: '11'
+ distribution: 'zulu'
+
+ - name: Caching dependencies
+ uses: actions/cache@v2
+ with:
+ path: ~/.hgexternalcache
+ key: ${{ runner.os }}-${{ hashFiles('*/external/binaries-list', '*/*/external/binaries-list') }}
+ restore-keys: ${{ runner.os }}-
+
+ - name: Checkout
+ uses: actions/checkout@v2
+
+ - name: Build NetBeans
+ run: ant -Dcluster.config=release build-nozip
+
+ - name: Archive Build
+ run: tar -czf /tmp/build.tar.gz --exclude ".git" .
+
+ - name: Upload Build
+ uses: actions/upload-artifact@v2
+ with:
+ name: build
+ path: /tmp/build.tar.gz
+ retention-days: 1
Review comment:
@neilcsmith-net excellent, meanwhile I am going to try to add a cleanup job: [9e719ee](https://github.com/apache/netbeans/pull/3785/commits/9e719ee57d8b1468b609cd264f4880901ec9e7d1)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien merged pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien merged pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1069176068
> JFTR - various ASF projects are using git submodules if there is a need for third-party actions - eg. see [apache/superset#12709](https://github.com/apache/superset/pull/12709)
hi @neilcsmith-net, I didn't know that windows learned what a tar is. It turns out that there is no need for that action. But good to know that there is a trick available if it would be still needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #3785: github actions ci pipeline.
Posted by GitBox <gi...@apache.org>.
mbien commented on pull request #3785:
URL: https://github.com/apache/netbeans/pull/3785#issuecomment-1068405648
windows tar.gz extractor action doesn't work anymore:
`ihiroky/extract-action@v1 is not allowed to be used in apache/netbeans. Actions in this workflow must be: within a repository owned by apache, created by GitHub, verified in the GitHub Marketplace or match the following: `
disabled win job for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists