[GitHub] [incubator-uniffle] leixm commented on a diff in pull request #879: [#133] feat(netty): Implement ShuffleServer interface.

["leixm (via GitHub)" <gi...@apache.org>]

leixm commented on code in PR #879:
URL: https://github.com/apache/incubator-uniffle/pull/879#discussion_r1193420415


##########
common/src/main/java/org/apache/uniffle/common/netty/handle/BaseMessageHandler.java:
##########
@@ -15,34 +15,26 @@
  * limitations under the License.
  */
 
-package org.apache.uniffle.server.netty.decoder;
+package org.apache.uniffle.common.netty.handle;
 
-import java.util.List;
+import org.apache.uniffle.common.netty.client.TransportClient;
+import org.apache.uniffle.common.netty.protocol.RequestMessage;
 
-import io.netty.buffer.ByteBuf;
-import io.netty.channel.ChannelHandlerContext;
-import io.netty.handler.codec.ByteToMessageDecoder;
+public class BaseMessageHandler {
 
-public class StreamServerInitDecoder extends ByteToMessageDecoder {
+  public void receive(TransportClient client, RequestMessage msg) {
+    throw new UnsupportedOperationException();
+  }
+
+  public void channelActive(TransportClient client) {
 
-  public StreamServerInitDecoder() {
   }
 
-  private void addDecoder(ChannelHandlerContext ctx, byte type) {
+  public void channelInactive(TransportClient client) {
 
   }
 
-  @Override
-  protected void decode(ChannelHandlerContext ctx,
-      ByteBuf in,
-      List<Object> out) {
-    if (in.readableBytes() < Byte.BYTES) {
-      return;
-    }
-    in.markReaderIndex();
-    byte magicByte = in.readByte();
-    in.resetReaderIndex();
-
-    addDecoder(ctx, magicByte);
+  public void exceptionCaught(Throwable cause, TransportClient client) {
+

Review Comment:
   Okay.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org