[GitHub] [ozone] symious commented on pull request #3350: HDDS-6648. Add Root in network-topology-default.xml

[GitBox <gi...@apache.org>]

symious commented on PR #3350:
URL: https://github.com/apache/ozone/pull/3350#issuecomment-1118134680

   @ChenSammi Thanks for the review.
   The descriptions had some flaws, update and fixed it.
   
   The problem I think is the content of the topology, in `network-topology-default.xml`, the topology is "/datacenter/rack/node", which is a 4 level topology, including "root, datacenter, rack and node", but the trick thing in "NodeSchemaLoader" is it ignores the first "/" so the schema becomes "datacenter/rack/node", which becomes a 3 level topology which fits the default setting for datanodes, that is "/default-rack/node1".
   
   I think it's better to remove the trick operation to reduce any possible misunderstandings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org