Re: [PR] [DRAFT] Change vector input from IndexInput to RandomAccessInput [lucene]

["shubhamvishu (via GitHub)" <gi...@apache.org>]

shubhamvishu commented on code in PR #13981:
URL: https://github.com/apache/lucene/pull/13981#discussion_r1836169057


##########
lucene/core/src/java21/org/apache/lucene/internal/vectorization/Lucene99MemorySegmentByteVectorScorer.java:
##########
@@ -40,8 +41,14 @@ abstract sealed class Lucene99MemorySegmentByteVectorScorer
    * returned.
    */
   public static Optional<Lucene99MemorySegmentByteVectorScorer> create(
-      VectorSimilarityFunction type, IndexInput input, KnnVectorValues values, byte[] queryVector) {
+      VectorSimilarityFunction type,
+      RandomAccessInput slice,
+      KnnVectorValues values,
+      byte[] queryVector) {
     assert values instanceof ByteVectorValues;
+    if (!(slice instanceof IndexInput input)) {

Review Comment:
   Nit : input is not used



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org