You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tinkerpop.apache.org by pietermartin <gi...@git.apache.org> on 2016/02/09 21:58:52 UTC
[GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
GitHub user pietermartin opened a pull request:
https://github.com/apache/incubator-tinkerpop/pull/221
clear graph after IoTest.shouldReadWriteSelfLoopingEdges test runs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/pietermartin/incubator-tinkerpop master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-tinkerpop/pull/221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #221
----
commit 59d1d31b9ada14c41ea6a6c142d9d0213267d5f7
Author: pieter <pi...@rorotika.com>
Date: 2016-02-09T20:56:16Z
clear graph after IoTest.shouldReadWriteSelfLoopingEdges test runs.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin closed the pull request at:
https://github.com/apache/incubator-tinkerpop/pull/221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/221#issuecomment-182553248
@pietermartin thanks for raising this issue and for offering a fix. i have a more complete solution to the problem on this #223 - can you please take a look and see if it works for you and sqlg?
If it works, I think you can close this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
Posted by Stephen Mallette <sp...@gmail.com>.
Great - can you please close the PR from your end?
On Tue, Feb 16, 2016 at 6:44 AM, pieter-gmail <pi...@gmail.com>
wrote:
> Hi,
>
> Just ran my tests on tp31 3.1.2-SNAPSHOT and all is well.
>
> Thanks
> Pieter
>
> On 12/02/2016 17:54, spmallette wrote:
> > Github user spmallette commented on the pull request:
> >
> >
> https://github.com/apache/incubator-tinkerpop/pull/221#issuecomment-183384012
> >
> > dah - there was a secondary problem at play here which i just
> noticed - fixed with this: e982a0c1b018604e13755ccad65e308b77018fc3
> >
> > this seems to work for titan now after this fix so i assume the
> problem is now resolved. @pietermartin if you can confirm, that would be
> great. not that this work is for 3.1.2-SNAPSHOT on the tp31 branch
> >
> >
> >
> >
> > ---
> > If your project is set up for it, you can reply to this email and have
> your
> > reply appear on GitHub as well. If your project does not have this
> feature
> > enabled and wishes so, or if the feature is enabled but not working,
> please
> > contact infrastructure at infrastructure@apache.org or file a JIRA
> ticket
> > with INFRA.
> > ---
>
>
Re: [GitHub] incubator-tinkerpop pull request: clear graph after
IoTest.shouldR...
Posted by pieter-gmail <pi...@gmail.com>.
Hi,
Just ran my tests on tp31 3.1.2-SNAPSHOT and all is well.
Thanks
Pieter
On 12/02/2016 17:54, spmallette wrote:
> Github user spmallette commented on the pull request:
>
> https://github.com/apache/incubator-tinkerpop/pull/221#issuecomment-183384012
>
> dah - there was a secondary problem at play here which i just noticed - fixed with this: e982a0c1b018604e13755ccad65e308b77018fc3
>
> this seems to work for titan now after this fix so i assume the problem is now resolved. @pietermartin if you can confirm, that would be great. not that this work is for 3.1.2-SNAPSHOT on the tp31 branch
>
>
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
[GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
Posted by spmallette <gi...@git.apache.org>.
Github user spmallette commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/221#issuecomment-183384012
dah - there was a secondary problem at play here which i just noticed - fixed with this: e982a0c1b018604e13755ccad65e308b77018fc3
this seems to work for titan now after this fix so i assume the problem is now resolved. @pietermartin if you can confirm, that would be great. not that this work is for 3.1.2-SNAPSHOT on the tp31 branch
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-tinkerpop pull request: clear graph after IoTest.shouldR...
Posted by pietermartin <gi...@git.apache.org>.
Github user pietermartin commented on the pull request:
https://github.com/apache/incubator-tinkerpop/pull/221#issuecomment-184651721
Fixed on tp31 3.1.2-SNAPSHOT
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---