[GitHub] [samza] mynameborat commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart

[GitBox <gi...@apache.org>]

mynameborat commented on a change in pull request #1219: SAMZA-2373: Container Placement Service (core functionality) for container move and restart
URL: https://github.com/apache/samza/pull/1219#discussion_r353492774
 
 

 ##########
 File path: samza-core/src/test/java/org/apache/samza/clustermanager/TestContainerProcessManager.java
 ##########
 @@ -625,7 +631,8 @@ public void testRerequestOnAnyHostIfContainerStartFails() throws Exception {
     configMap.putAll(getConfig());
     MockClusterResourceManagerCallback callback = new MockClusterResourceManagerCallback();
     MockClusterResourceManager clusterResourceManager = new MockClusterResourceManager(callback, state);
-    ContainerManager containerManager = new ContainerManager(state, clusterResourceManager, false);
+    ContainerManager containerManager = new ContainerManager(state, clusterResourceManager,
+        Boolean.valueOf(config.get(ClusterManagerConfig.HOST_AFFINITY_ENABLED)), false);
 
 Review comment:
   `getBoolean` has an overload that takes a default to be returned in case of null

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services