You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/03/09 07:07:38 UTC
[GitHub] [incubator-nuttx] masayuki2009 opened a new pull request #502:
tools: Add workaround not to build in parallel for ELF in testbuild.sh
masayuki2009 opened a new pull request #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502
### Summary
- As long as I checked nightly build results, build errors sometimes happen if a target has CONFIG_ELF=y. I think there still have a root cause in parallel build but I'd like to propose this PR to avoid such a parallel build error.
### Impact
- This PR affects testbuild (e.g. build time will be longer) if a target configuration has CONFIG_ELF=y
- However, as long as I checked all configurations, only 4% defconfigs have CONFIG_ELF=y.
### Limitations / TODO
- It seems that kostest sometimes causes build errors but I'm not sure why this happens.
### Testing
- I tested this PR for RISC-V targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #502: tools: Add
workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-596372830
@xiaoxiang781216,
> How about let's try to fix it first?
Hmm, the build system is much complicated than I thought.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 closed pull request #502: tools:
Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 closed pull request #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #502: tools:
Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-597465512
> Hi, @xiaoxiang781216
>
> I might find the root cause. Now I'm repeating parallel build aging test with -j1 to -j24 options.
> And it seems to be stable now. So I'll send a new PR later.
Great! We can get the stable nightly build soon, thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #502: tools:
Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-596367333
@masayuki2009 do you mean this error:
```
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function `elf_main':
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.
```
How about let's try to fix it first?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #502: tools: Add
workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-597442522
> Hi, @xiaoxiang781216
>
> I might find the root cause. Now I'm repeating parallel build aging test with -j1 to -j24 options.
> And it seems to be stable now. So I'll send a new PR later.
https://github.com/apache/incubator-nuttx-apps/pull/118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on issue #502: tools: Add
workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-597429046
Hi, @xiaoxiang781216
I might find the root cause. Now I'm repeating parallel build aging test with -j1 to -j24 options.
And it seems to be stable now. So I'll send a new PR later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #502: tools:
Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-599199712
As we try to fix the root cause, let's close this workaround PR now:
https://github.com/apache/incubator-nuttx-apps/pull/118
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] masayuki2009 commented on a change in pull
request #502: tools: Add workaround not to build in parallel for ELF in
testbuild.sh
Posted by GitBox <gi...@apache.org>.
masayuki2009 commented on a change in pull request #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#discussion_r390027526
##########
File path: tools/testbuild.sh
##########
@@ -190,7 +190,16 @@ function configure {
function build {
echo " Building NuttX..."
echo "------------------------------------------------------------------------------------"
- makefunc ${JOPTION} ${MAKE_FLAGS} 1>/dev/null
+
+ elf=`grep CONFIG_ELF=y $nuttx/.config`
Review comment:
@liuguo09 Thanks for the comment, I'll fix it later.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 edited a comment on issue #502:
tools: Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 edited a comment on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-596367333
@masayuki2009 do you mean this error:
```
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/nuttx/staging/libapps.a(elf_main.home.jenkins.jenkins-slave.workspace.NuttX-Nightly-Build.apps.examples.elf.o): in function `elf_main':
/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_nexports'
riscv64-unknown-elf-ld: /home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/examples/elf/elf_main.c:357: undefined reference to `g_elf_exports'
make[1]: *** [nuttx] Error 1
make: *** [pass2] Error 2
make: Target 'all' not remade because of errors.
```
As I know we just have two parallel build issues, another one is:
```
mv: cannot stat '.xx_builtin_list.h': No such file or directory
make[2]: *** [builtin_list.h] Error 1
make[2]: Target 'depend' not remade because of errors.
make[2]: Target 'depend' not remade because of errors.
make[1]: *** [/home/jenkins/jenkins-slave/workspace/NuttX-Nightly-Build/apps/builtin_depend] Error 2
make[1]: Target 'depend' not remade because of errors.
```
We have fixed many parallel build in recent months, how about let's try our best to fix the last two if we can?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on issue #502: tools:
Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on issue #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#issuecomment-596376634
> @xiaoxiang781216,
>
> > How about let's try to fix it first?
>
> Hmm, the build system is much complicated than I thought.
Yes, we need more help from the community, but the good thing is that this type of error just happen with a large number of cpu, github action run with -j2 normally don't hit them. So the daily workfolow process don't get stuck at least, and we have some buffer to fix them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-nuttx] liuguo09 commented on a change in pull request
#502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
Posted by GitBox <gi...@apache.org>.
liuguo09 commented on a change in pull request #502: tools: Add workaround not to build in parallel for ELF in testbuild.sh
URL: https://github.com/apache/incubator-nuttx/pull/502#discussion_r389525319
##########
File path: tools/testbuild.sh
##########
@@ -190,7 +190,16 @@ function configure {
function build {
echo " Building NuttX..."
echo "------------------------------------------------------------------------------------"
- makefunc ${JOPTION} ${MAKE_FLAGS} 1>/dev/null
+
+ elf=`grep CONFIG_ELF=y $nuttx/.config`
Review comment:
I think elf line should write as elf=`grep CONFIG_ELF=y $nuttx/.config || true` to fix check build break as https://github.com/apache/incubator-nuttx/pull/422 blacklist does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services