You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/09/04 15:46:46 UTC
[GitHub] [incubator-nuttx] johannes-nivus opened a new pull request #1713: Buildsys
johannes-nivus opened a new pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713
## Summary
Changes to the Build System.
## Impact
export target was broken (#1679), now it builds again.
There was no __KERNEL__ flag for libboard. (I wasn't able to use rtc_initialize from bringup, because it is guarded by __KERNEL__).
## Testing
Kinetis K28, Unix host under MSYS2.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713#discussion_r483928737
##########
File path: arch/arm/src/Makefile
##########
@@ -165,7 +165,7 @@ $(KBIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
board$(DELIM)libboard$(LIBEXT):
- $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
+ $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)"
Review comment:
This is a pure makefile change, so it's good after other arch change pass the build.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713#discussion_r483755854
##########
File path: arch/arm/src/Makefile
##########
@@ -165,7 +165,7 @@ $(KBIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
board$(DELIM)libboard$(LIBEXT):
- $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
+ $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)"
Review comment:
need for all other arch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] johannes-nivus commented on a change in pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on a change in pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713#discussion_r483945784
##########
File path: arch/arm/src/Makefile
##########
@@ -165,7 +165,7 @@ $(KBIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
board$(DELIM)libboard$(LIBEXT):
- $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
+ $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)"
Review comment:
Done. You told me to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] johannes-nivus commented on a change in pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
johannes-nivus commented on a change in pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713#discussion_r483766184
##########
File path: arch/arm/src/Makefile
##########
@@ -165,7 +165,7 @@ $(KBIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
board$(DELIM)libboard$(LIBEXT):
- $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
+ $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)"
Review comment:
Can't test all other arch. Will open an Issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #1713: Buildsystem fix
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #1713:
URL: https://github.com/apache/incubator-nuttx/pull/1713#discussion_r483951007
##########
File path: arch/arm/src/Makefile
##########
@@ -165,7 +165,7 @@ $(KBIN): $(OBJS)
$(call ARCHIVE, $@, $(OBJS))
board$(DELIM)libboard$(LIBEXT):
- $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(EXTRAFLAGS)"
+ $(Q) $(MAKE) -C board TOPDIR="$(TOPDIR)" libboard$(LIBEXT) EXTRAFLAGS="$(KDEFINE) $(EXTRAFLAGS)"
Review comment:
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org